Skip to content

Commit 6da743c

Browse files
committed
Use set instead of list
1 parent 9aed5b2 commit 6da743c

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/pip/_internal/commands/show.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -100,11 +100,11 @@ def _get_requiring_packages(current_dist: BaseDistribution) -> Iterator[str]:
100100
except KeyError:
101101
continue
102102

103-
requires = []
103+
requires = {}
104104
# Avoid duplicates in requirements due to environment markers
105105
for req in dist.iter_dependencies():
106106
if req.name not in requires:
107-
requires.append(req.name)
107+
requires.add(req.name)
108108
requires = sorted(requires, key=str.lower)
109109
required_by = sorted(_get_requiring_packages(dist), key=str.lower)
110110

tests/functional/test_show.py

+1
Original file line numberDiff line numberDiff line change
@@ -364,6 +364,7 @@ def test_show_deduplicate_requirements(script: PipTestEnvironment) -> None:
364364
name="simple",
365365
version="1.0",
366366
install_requires=[
367+
"pip >= 19.0.1",
367368
'pip >= 19.3.1; python_version < "3.8"',
368369
'pip >= 23.0.1; python_version < "3.9"',
369370
],

0 commit comments

Comments
 (0)