Skip to content

Commit 7fb6634

Browse files
committed
Revert back to using options=None and fix loose ends
1 parent 1466136 commit 7fb6634

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

pip/req/req_install.py

+6-5
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class InstallRequirement(object):
4848

4949
def __init__(self, req, comes_from, source_dir=None, editable=False,
5050
link=None, as_egg=False, update=True, editable_options=None,
51-
pycompile=True, markers=None, isolated=False, options={}):
51+
pycompile=True, markers=None, isolated=False, options=None):
5252
self.extras = ()
5353
if isinstance(req, six.string_types):
5454
req = pkg_resources.Requirement.parse(req)
@@ -86,15 +86,14 @@ def __init__(self, req, comes_from, source_dir=None, editable=False,
8686
self.uninstalled = None
8787
self.use_user_site = False
8888
self.target_dir = None
89-
self.options = options
90-
89+
self.options = options if options else {}
9190
self.pycompile = pycompile
9291

9392
self.isolated = isolated
9493

9594
@classmethod
9695
def from_editable(cls, editable_req, comes_from=None, default_vcs=None,
97-
isolated=False):
96+
isolated=False, options=None):
9897
from pip.index import Link
9998

10099
name, url, extras_override, editable_options = parse_editable(
@@ -108,7 +107,8 @@ def from_editable(cls, editable_req, comes_from=None, default_vcs=None,
108107
editable=True,
109108
link=Link(url),
110109
editable_options=editable_options,
111-
isolated=isolated)
110+
isolated=isolated,
111+
options=options if options else {})
112112

113113
if extras_override is not None:
114114
res.extras = extras_override
@@ -181,6 +181,7 @@ def from_line(cls, name, comes_from=None, isolated=False, options=None):
181181
else:
182182
req = name
183183

184+
options = options if options else {}
184185
return cls(req, comes_from, link=link, markers=markers,
185186
isolated=isolated, options=options)
186187

0 commit comments

Comments
 (0)