Skip to content

Commit 826d566

Browse files
committed
Add a spinner when preparing setup.py metadata
For symmetry with pyproject.toml metadata preparation.
1 parent 74999cc commit 826d566

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

src/pip/_internal/operations/build/metadata_legacy.py

+8-5
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import os
66

77
from pip._internal.build_env import BuildEnvironment
8+
from pip._internal.cli.spinners import open_spinner
89
from pip._internal.exceptions import InstallationError
910
from pip._internal.utils.setuptools_build import make_setuptools_egg_info_args
1011
from pip._internal.utils.subprocess import call_subprocess
@@ -54,11 +55,13 @@ def generate_metadata(
5455
)
5556

5657
with build_env:
57-
call_subprocess(
58-
args,
59-
cwd=source_dir,
60-
command_desc="python setup.py egg_info",
61-
)
58+
with open_spinner("Preparing metadata (setup.py)") as spinner:
59+
call_subprocess(
60+
args,
61+
cwd=source_dir,
62+
command_desc="python setup.py egg_info",
63+
spinner=spinner,
64+
)
6265

6366
# Return the .egg-info directory.
6467
return _find_egg_info(egg_info_dir)

src/pip/_internal/req/req_install.py

+4
Original file line numberDiff line numberDiff line change
@@ -528,6 +528,10 @@ def _generate_editable_metadata(self) -> str:
528528
# At this point we have determined that the build_editable hook
529529
# is missing, and there is a setup.py or setup.cfg
530530
# so we fallback to the legacy metadata generation
531+
logger.info(
532+
"Build backend does not support editables, "
533+
"falling back to setup.py egg_info."
534+
)
531535
else:
532536
self.supports_pyproject_editable = True
533537
return metadata_directory

0 commit comments

Comments
 (0)