Skip to content

Commit ac19f79

Browse files
committed
Follow imports for more vendored dependencies
This will allow mypy to notice if you e.g. try to call a colorama function that does not exist. Note we won't report any errors in vendored code due to the ignore_errors config above. It would also be quite easy to let mypy look at pkg_resources code, but this would involve the addition of like three type ignores.
1 parent eddd9dd commit ac19f79

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

news/12AE57EC-683C-4A8E-BCCB-851FCD0730B4.trivial.rst

Whitespace-only changes.

setup.cfg

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,8 @@ ignore_errors = True
5454
# These vendored libraries use runtime magic to populate things and don't sit
5555
# well with static typing out of the box. Eventually we should provide correct
5656
# typing information for their public interface and remove these configs.
57-
[mypy-pip._vendor.colorama]
58-
follow_imports = skip
5957
[mypy-pip._vendor.pkg_resources]
6058
follow_imports = skip
61-
[mypy-pip._vendor.progress.*]
62-
follow_imports = skip
6359
[mypy-pip._vendor.requests.*]
6460
follow_imports = skip
6561

0 commit comments

Comments
 (0)