Skip to content

Commit acbbe28

Browse files
committed
Postpone removal of non-bare names in egg fragment to 25.1
The only way for editable VCS URL installs to request an extra is to place them in the egg fragment. Of course, this is undocumented and deprecated behaviour, but we should ensure `pip install -e name[extra] @ VCS_URL` actually works before breaking our users.
1 parent 1452429 commit acbbe28

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/pip/_internal/cli/base_command.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ def _main(self, args: List[str]) -> int:
231231

232232
if options.no_python_version_warning:
233233
deprecated(
234-
reason="--no-python-verison-warning is deprecated.",
234+
reason="--no-python-version-warning is deprecated.",
235235
replacement="to remove the flag as it's a no-op",
236236
gone_in="25.1",
237237
issue=13154,

src/pip/_internal/models/link.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -466,10 +466,10 @@ def _egg_fragment(self) -> Optional[str]:
466466
project_name = match.group(1)
467467
if not self._project_name_re.match(project_name):
468468
deprecated(
469-
reason=f"{self} contains an egg fragment with a non-PEP 508 name",
469+
reason=f"{self} contains an egg fragment with a non-PEP 508 name.",
470470
replacement="to use the req @ url syntax, and remove the egg fragment",
471-
gone_in="25.0",
472-
issue=11617,
471+
gone_in="25.1",
472+
issue=13157,
473473
)
474474

475475
return project_name

0 commit comments

Comments
 (0)