Skip to content

Commit b989e6e

Browse files
authored
Merge pull request #12919 from mayeut/ci-mac-arm64
2 parents ac63d0f + 964229e commit b989e6e

File tree

4 files changed

+22
-5
lines changed

4 files changed

+22
-5
lines changed

.github/workflows/ci.yml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ on:
1010
pull_request:
1111
schedule:
1212
- cron: 0 0 * * MON # Run every Monday at 00:00 UTC
13+
workflow_dispatch:
14+
# allow manual runs on branches without a PR
1315

1416
env:
1517
# The "FORCE_COLOR" variable, when set to 1,
@@ -110,7 +112,7 @@ jobs:
110112
strategy:
111113
fail-fast: true
112114
matrix:
113-
os: [ubuntu-latest, macos-12]
115+
os: [ubuntu-latest, macos-12, macos-latest]
114116
python:
115117
- "3.8"
116118
- "3.9"
@@ -133,8 +135,13 @@ jobs:
133135
sudo apt-get install bzr
134136
135137
- name: Install MacOS dependencies
136-
if: matrix.os == 'macos-12'
137-
run: brew install breezy
138+
if: runner.os == 'macOS'
139+
run: |
140+
DEPS=breezy
141+
if ! which svn; then
142+
DEPS="${DEPS} subversion"
143+
fi
144+
brew install ${DEPS}
138145
139146
- run: pip install nox
140147

news/F2CF2568-49B1-49EF-8B16-70491B9C8FDA.trivial.rst

Whitespace-only changes.

tests/functional/test_uninstall_user.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
tests specific to uninstalling --user installs
33
"""
44

5+
import platform
6+
import sys
57
from os.path import isdir, isfile, normcase
68

79
import pytest
@@ -74,6 +76,12 @@ def test_uninstall_from_usersite_with_dist_in_global_site(
7476
dist_info_folder = script.base_path / script.site_packages / "pkg-0.1.dist-info"
7577
assert isdir(dist_info_folder)
7678

79+
@pytest.mark.xfail(
80+
sys.platform == "darwin"
81+
and platform.machine() == "arm64"
82+
and sys.version_info[:2] in {(3, 8), (3, 9)},
83+
reason="Unexpected egg-link install path",
84+
)
7785
def test_uninstall_editable_from_usersite(
7886
self, script: PipTestEnvironment, data: TestData
7987
) -> None:

tests/requirements.txt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,10 @@ pytest-rerunfailures
88
pytest-xdist
99
scripttest
1010
setuptools
11-
virtualenv < 20.0 ; python_version < '3.10'
12-
virtualenv >= 20.0 ; python_version >= '3.10'
11+
# macOS (darwin) arm64 always uses virtualenv >= 20.0
12+
# for other platforms, it depends on python version
13+
virtualenv < 20.0 ; python_version < '3.10' and (sys_platform != 'darwin' or platform_machine != 'arm64')
14+
virtualenv >= 20.0 ; python_version >= '3.10' or (sys_platform == 'darwin' and platform_machine == 'arm64')
1315
werkzeug
1416
wheel
1517
tomli-w

0 commit comments

Comments
 (0)