Merge pull request #8282 from uranusjr/pre-existing-build-directory-reprod

Add reprod for pre-existing build dir failure

Author: pfmoore

tests/functional/test_new_resolver.py

@@ -3,6 +3,7 @@
 import sys
 
 import pytest
+from pip._vendor.packaging.utils import canonicalize_name
 
 from tests.lib import (
     create_basic_sdist_for_package,
@@ -14,20 +15,25 @@
 def assert_installed(script, **kwargs):
     ret = script.pip('list', '--format=json')
     installed = set(
-        (val['name'], val['version'])
+        (canonicalize_name(val['name']), val['version'])
         for val in json.loads(ret.stdout)
     )
-    assert set(kwargs.items()) <= installed, \
-        "{!r} not all in {!r}".format(kwargs, installed)
+    expected = set((canonicalize_name(k), v) for k, v in kwargs.items())
+    assert expected <= installed, \
+        "{!r} not all in {!r}".format(expected, installed)
 
 
 def assert_not_installed(script, *args):
     ret = script.pip("list", "--format=json")
-    installed = set(val["name"] for val in json.loads(ret.stdout))
+    installed = set(
+        canonicalize_name(val["name"])
+        for val in json.loads(ret.stdout)
+    )
     # None of the given names should be listed as installed, i.e. their
     # intersection should be empty.
-    assert not (set(args) & installed), \
-        "{!r} contained in {!r}".format(args, installed)
+    expected = set(canonicalize_name(k) for k in args)
+    assert not (expected & installed), \
+        "{!r} contained in {!r}".format(expected, installed)
 
 
 def assert_editable(script, *args):
@@ -855,3 +861,43 @@ def test_new_resolver_extra_merge_in_package(
             requirement + "[dev]",
         )
         assert_installed(script, pkg="1.0.0", dep="1.0.0", depdev="1.0.0")
+
+
+@pytest.mark.xfail(reason="pre-existing build directory")
+def test_new_resolver_build_directory_error_zazo_19(script):
+    """https://github.com/pradyunsg/zazo/issues/19#issuecomment-631615674
+
+    This will first resolve like this:
+
+    1. Pin pkg-b==2.0.0 (since pkg-b has fewer choices)
+    2. Pin pkg-a==3.0.0 -> Conflict due to dependency pkg-b<2
+    3. Pin pkg-b==1.0.0
+
+    Since pkg-b is only available as sdist, both the first and third steps
+    would trigger building from source. This ensures the preparer can build
+    different versions of a package for the resolver.
+
+    The preparer would fail with the following message if the different
+    versions end up using the same build directory::
+
+        ERROR: pip can't proceed with requirements 'pkg-b ...' due to a
+        pre-existing build directory (...). This is likely due to a previous
+        installation that failed. pip is being responsible and not assuming it
+        can delete this. Please delete it and try again.
+    """
+    create_basic_wheel_for_package(
+        script, "pkg_a", "3.0.0", depends=["pkg-b<2"],
+    )
+    create_basic_wheel_for_package(script, "pkg_a", "2.0.0")
+    create_basic_wheel_for_package(script, "pkg_a", "1.0.0")
+
+    create_basic_sdist_for_package(script, "pkg_b", "2.0.0")
+    create_basic_sdist_for_package(script, "pkg_b", "1.0.0")
+
+    script.pip(
+        "install", "--unstable-feature=resolver",
+        "--no-cache-dir", "--no-index",
+        "--find-links", script.scratch_path,
+        "pkg-a", "pkg-b",
+    )
+    assert_installed(script, pkg_a="3.0.0", pkg_b="1.0.0")