Skip to content

Commit f841076

Browse files
committed
Add a TODO
1 parent 78b4a30 commit f841076

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/pip/_internal/req/req_install.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -627,6 +627,8 @@ def prepare_pep517_metadata(self):
627627

628628
self.metadata_directory = os.path.join(metadata_dir, distinfo_dir)
629629

630+
# NOTE: This is only used in get_dist(), so look into eagerly assigning to
631+
# metadata_directory in this case, once metadata is generated.
630632
@property
631633
def egg_info_path(self):
632634
# type: () -> str
@@ -702,6 +704,7 @@ def get_dist(self):
702704
dist_dir = self.egg_info_path.rstrip(os.path.sep)
703705
# https://github.com/python/mypy/issues/1174
704706
dist_cls = pkg_resources.Distribution # type: ignore
707+
# dist_dir_name can be of the form "<project>.dist-info" or
705708
# e.g. "<project>.egg-info".
706709
base_dir, dist_dir_name = os.path.split(dist_dir)
707710
dist_name = os.path.splitext(dist_dir_name)[0]

0 commit comments

Comments
 (0)