-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add new option --rebuild (or --never-binary) to the install command #13088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Since the issue seems very much related to caching, I wonder if options to provide finer grained control of the cache of locally built wheels would address the use case too. |
I agree with @sbidoul here. I would prefer to see this named in a way that makes it clear that it's about using the cache. So something like The invocation would then be:
For me, |
With all the respect that I have for you @pfmoore and @sbidoul, it seems to me that you take the point of view of pip developers (who know the internal details) to think about the design of the user API. From the point of view of users, we don't care about caching. What some users want is the possibility to ask for installation of few packages with new builds from source (and clearly most of the times IMHO, we really need to find a good solution to avoid things like: pip cache remove h5py; pip install h5py --no-binary h5py --force and take into account the need of users that used What about With pip install mpi4py pyfftw h5py --no-build-cache mpi4py --no-build-cache pyfftw --no-build-cache h5py --force (which is ugly and would force reinstallation of many other dependencies, which is not what we want) pip install mpi4py pyfftw h5py --new-build is much simpler and cleaner. |
I think that worrying about the name is probably a mistake at this point. We need a clean design first, and then someone needs to create a PR. Until both of those things happen, worrying about the option name is proably premature. As far as design is concerned, my first question is, does the user always want every project to be rebuilt from source? Even dependencies? That's a genuine question, I have no knowledge of HPC-style workflows. If so, then I guess a But if we ever want to allow previous builds of anything to be used (for example, a pure Python dependency like
I hope we don't - I certainly try not to. But I'll concede that most users shouldn't need to know or care about the wheel cache. Having said that, though, most users don't reconfigure build options between installs. So using the cache is a significant benefit, at no real cost, for most of our users. For those users like yourself where it isn't a benefit, we should have an option to bypass the cache, I agree. But without some perspective on how you view what you're doing (which you gave in your last message) it's hard to know what form the UI should take. I'll also note that pip is intended as an install tool, not as a build tool. The fact that pip builds packages when there are no binaries available is intended itself to be an implementation detail the user shouldn't care about. So from that perspective, using But anyway, I think the next steps are for someone (I don't know if it's something you are offering to do) to:
|
Uh oh!
There was an error while loading. Please reload this page.
What's the problem this feature will solve?
I try to split issue #12954 in smaller and more tractable issues.
As discussed in detailed in #12954, the option
--no-binary
was used in particular for HPC to rebuild a package from source with different build arguments or different libraries (for example hdf5 sequential/parallel, or openMPI/MPICH).However, since 23.1 (https://pip.pypa.io/en/stable/news/#v23-1), "--no-binary does not disable the cache of locally built wheels anymore. It only means “don’t download wheels”. (#11453)".
As pointed out here, web documentation and supercomputer tutorials still use
--no-binary
for this purpose because of the old behavior (before 23.1) and the misleading name of this option (--no-binary
only means “don’t download wheels”).For this purpose ("reinstall a package from source"), one now needs to run things like:
Such commands are quite ugly, long and error prone. Note the "pyFFTW" and "fluidfft_fftwmpi", whereas the packages are named pyfftw and fluidfft-fftwmpi (#13086).
Describe the solution you'd like
I propose to add a
--rebuild
option so that(re)installs pyfftw from source (no wheel at all).
It seems to me that it would be convenient to be able to use
--rebuild
alone (like above, equivalent topip install pyfftw --rebuild pyfftw
) or aslike for
--no-binary
.I think
should be equivalent to
Alternative Solutions
Other name like
--never-binary
could be used.Additional context
Code of Conduct
The text was updated successfully, but these errors were encountered: