Skip to content

Commit 91895aa

Browse files
authored
Merge pull request #149 from FFY00/remove-chain-exception-prepare-hook
Remove chained exception when the prepare_metadata_for_build_wheel hook is missing
2 parents cc68a41 + 93a247f commit 91895aa

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

pep517/in_process/_in_process.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,11 +145,13 @@ def prepare_metadata_for_build_wheel(
145145
except AttributeError:
146146
if not _allow_fallback:
147147
raise HookMissing()
148-
whl_basename = backend.build_wheel(metadata_directory, config_settings)
149-
return _get_wheel_metadata_from_wheel(whl_basename, metadata_directory,
150-
config_settings)
151148
else:
152149
return hook(metadata_directory, config_settings)
150+
# fallback to build_wheel outside the try block to avoid exception chaining
151+
# which can be confusing to users and is not relevant
152+
whl_basename = backend.build_wheel(metadata_directory, config_settings)
153+
return _get_wheel_metadata_from_wheel(whl_basename, metadata_directory,
154+
config_settings)
153155

154156

155157
def prepare_metadata_for_build_editable(

0 commit comments

Comments
 (0)