Merge pull request #120 from domdfcoding/toml-utf8

Use UTF-8 encoding when reading pyproject.toml

Author: takluyver

pep517/build.py

@@ -1,6 +1,7 @@
 """Build a project using PEP 517 hooks.
 """
 import argparse
+import io
 import logging
 import os
 import shutil
@@ -30,7 +31,7 @@ def load_system(source_dir):
     Load the build system from a source dir (pyproject.toml).
     """
     pyproject = os.path.join(source_dir, 'pyproject.toml')
-    with open(pyproject) as f:
+    with io.open(pyproject, encoding="utf-8") as f:
         pyproject_data = toml_load(f)
     return pyproject_data['build-system']
 

pep517/check.py

@@ -1,6 +1,7 @@
 """Check a project and backend by attempting to build using PEP 517 hooks.
 """
 import argparse
+import io
 import logging
 import os
 from os.path import isfile, join as pjoin
@@ -141,7 +142,7 @@ def check(source_dir):
         return False
 
     try:
-        with open(pyproject) as f:
+        with io.open(pyproject, encoding="utf-8") as f:
             pyproject_data = toml_load(f)
         # Ensure the mandatory data can be loaded
         buildsys = pyproject_data['build-system']

pep517/envbuild.py

@@ -1,6 +1,7 @@
 """Build wheels/sdists by installing build deps to a temporary environment.
 """
 
+import io
 import os
 import logging
 import shutil
@@ -16,7 +17,10 @@
 
 
 def _load_pyproject(source_dir):
-    with open(os.path.join(source_dir, 'pyproject.toml')) as f:
+    with io.open(
+            os.path.join(source_dir, 'pyproject.toml'),
+            encoding="utf-8",
+            ) as f:
         pyproject_data = toml_load(f)
     buildsys = pyproject_data['build-system']
     return (

tests/samples/pkg1/pyproject.toml

@@ -1,3 +1,7 @@
 [build-system]
 requires = ["eg_buildsys"]
 build-backend = "buildsys"
+
+[project]
+description = "Factory ⸻ A code generator 🏭"
+maintainers = [{name = "Łukasz Langa"}]

tests/test_call_hooks.py

@@ -1,3 +1,4 @@
+import io
 import os
 from os.path import dirname, abspath, join as pjoin
 import tarfile
@@ -28,7 +29,7 @@
 
 def get_hooks(pkg, **kwargs):
     source_dir = pjoin(SAMPLES_DIR, pkg)
-    with open(pjoin(source_dir, 'pyproject.toml')) as f:
+    with io.open(pjoin(source_dir, 'pyproject.toml'), encoding="utf-8") as f:
         data = toml_load(f)
     return Pep517HookCaller(
         source_dir, data['build-system']['build-backend'], **kwargs

tests/test_hook_fallbacks.py

@@ -1,3 +1,4 @@
+import io
 from os.path import dirname, abspath, join as pjoin
 import pytest
 from testpath import modified_env, assert_isfile
@@ -12,7 +13,7 @@
 
 def get_hooks(pkg):
     source_dir = pjoin(SAMPLES_DIR, pkg)
-    with open(pjoin(source_dir, 'pyproject.toml')) as f:
+    with io.open(pjoin(source_dir, 'pyproject.toml'), encoding="utf-8") as f:
         data = toml_load(f)
     return Pep517HookCaller(source_dir, data['build-system']['build-backend'])
 

tests/test_inplace_hooks.py

@@ -1,3 +1,4 @@
+import io
 from os.path import dirname, abspath, join as pjoin
 from testpath import modified_env
 import pytest
@@ -12,7 +13,7 @@
 
 def get_hooks(pkg, backend=None, path=None):
     source_dir = pjoin(SAMPLES_DIR, pkg)
-    with open(pjoin(source_dir, 'pyproject.toml')) as f:
+    with io.open(pjoin(source_dir, 'pyproject.toml'), encoding="utf-8") as f:
         data = toml_load(f)
     if backend is None:
         backend = data['build-system']['build-backend']