Skip to content

Commit 0f6055c

Browse files
authored
Consistently using sys.version_info as a NamedTuple (#4720)
2 parents fcdaf02 + cd0ef12 commit 0f6055c

File tree

8 files changed

+15
-17
lines changed

8 files changed

+15
-17
lines changed

pkg_resources/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ class UnknownExtra(ResolutionError):
387387

388388
_provider_factories: dict[type[_ModuleLike], _ProviderFactoryType] = {}
389389

390-
PY_MAJOR = '{}.{}'.format(*sys.version_info)
390+
PY_MAJOR = f'{sys.version_info.major}.{sys.version_info.minor}'
391391
EGG_DIST = 3
392392
BINARY_DIST = 2
393393
SOURCE_DIST = 1

pkg_resources/tests/test_resources.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ def testDistroBasics(self):
119119
self.checkFooPkg(d)
120120

121121
d = Distribution("/some/path")
122-
assert d.py_version == '{}.{}'.format(*sys.version_info)
122+
assert d.py_version == f'{sys.version_info.major}.{sys.version_info.minor}'
123123
assert d.platform is None
124124

125125
def testDistroParse(self):

setuptools/command/bdist_wheel.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def _is_32bit_interpreter() -> bool:
6464

6565

6666
def python_tag() -> str:
67-
return f"py{sys.version_info[0]}"
67+
return f"py{sys.version_info.major}"
6868

6969

7070
def get_platform(archive_root: str | None) -> str:
@@ -483,7 +483,7 @@ def run(self):
483483
# Add to 'Distribution.dist_files' so that the "upload" command works
484484
getattr(self.distribution, "dist_files", []).append((
485485
"bdist_wheel",
486-
"{}.{}".format(*sys.version_info[:2]), # like 3.7
486+
f"{sys.version_info.major}.{sys.version_info.minor}",
487487
wheel_path,
488488
))
489489

setuptools/command/easy_install.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -234,10 +234,9 @@ def _render_version():
234234
"""
235235
Render the Setuptools version and installation details, then exit.
236236
"""
237-
ver = '{}.{}'.format(*sys.version_info)
237+
ver = f'{sys.version_info.major}.{sys.version_info.minor}'
238238
dist = get_distribution('setuptools')
239-
tmpl = 'setuptools {dist.version} from {dist.location} (Python {ver})'
240-
print(tmpl.format(**locals()))
239+
print(f'setuptools {dist.version} from {dist.location} (Python {ver})')
241240
raise SystemExit
242241

243242
def finalize_options(self): # noqa: C901 # is too complex (25) # FIXME
@@ -1441,7 +1440,7 @@ def get_site_dirs():
14411440
os.path.join(
14421441
prefix,
14431442
"lib",
1444-
"python{}.{}".format(*sys.version_info),
1443+
f"python{sys.version_info.major}.{sys.version_info.minor}",
14451444
"site-packages",
14461445
),
14471446
os.path.join(prefix, "lib", "site-python"),
@@ -1468,7 +1467,7 @@ def get_site_dirs():
14681467
home,
14691468
'Library',
14701469
'Python',
1471-
'{}.{}'.format(*sys.version_info),
1470+
f'{sys.version_info.major}.{sys.version_info.minor}',
14721471
'site-packages',
14731472
)
14741473
sitedirs.append(home_sp)

setuptools/command/egg_info.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
from distutils.filelist import FileList as _FileList
3232
from distutils.util import convert_path
3333

34-
PY_MAJOR = '{}.{}'.format(*sys.version_info)
34+
PY_MAJOR = f'{sys.version_info.major}.{sys.version_info.minor}'
3535

3636

3737
def translate_pattern(glob): # noqa: C901 # is too complex (14) # FIXME

setuptools/package_index.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,7 @@
6464

6565
_SOCKET_TIMEOUT = 15
6666

67-
_tmpl = "setuptools/{setuptools.__version__} Python-urllib/{py_major}"
68-
user_agent = _tmpl.format(
69-
py_major='{}.{}'.format(*sys.version_info), setuptools=setuptools
70-
)
67+
user_agent = f"setuptools/{setuptools.__version__} Python-urllib/{sys.version_info.major}.{sys.version_info.minor}"
7168

7269

7370
def parse_requirement_arg(spec):

setuptools/tests/test_easy_install.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -859,7 +859,9 @@ def test_setup_requires_with_python_requires(self, monkeypatch, tmpdir):
859859
)
860860
dep_2_0_sdist = 'dep-2.0.tar.gz'
861861
dep_2_0_url = path_to_url(str(tmpdir / dep_2_0_sdist))
862-
dep_2_0_python_requires = '!=' + '.'.join(map(str, sys.version_info[:2])) + '.*'
862+
dep_2_0_python_requires = (
863+
f'!={sys.version_info.major}.{sys.version_info.minor}.*'
864+
)
863865
make_python_requires_sdist(
864866
str(tmpdir / dep_2_0_sdist), 'dep', '2.0', dep_2_0_python_requires
865867
)

setuptools/tests/test_egg_info.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -261,11 +261,11 @@ def _setup_script_with_requires(self, requires, use_setup_cfg=False):
261261
})
262262

263263
mismatch_marker = "python_version<'{this_ver}'".format(
264-
this_ver=sys.version_info[0],
264+
this_ver=sys.version_info.major,
265265
)
266266
# Alternate equivalent syntax.
267267
mismatch_marker_alternate = 'python_version < "{this_ver}"'.format(
268-
this_ver=sys.version_info[0],
268+
this_ver=sys.version_info.major,
269269
)
270270
invalid_marker = "<=>++"
271271

0 commit comments

Comments
 (0)