Merge pull request pypa/distutils#330 from Avasam/Make-sdist.metadata_check-an-actual-boolean

Make `sdist.metadata_check` an actual boolean

Author: jaraco

distutils/command/sdist.py

@@ -34,7 +34,7 @@ def show_formats():
 class sdist(Command):
     description = "create a source distribution (tarball, zip file, etc.)"
 
-    def checking_metadata(self):
+    def checking_metadata(self) -> bool:
         """Callable used for the check sub-command.
 
         Placed here so user_options can view it"""
@@ -136,7 +136,7 @@ def initialize_options(self):
         self.dist_dir = None
 
         self.archive_files = None
-        self.metadata_check = 1
+        self.metadata_check = True
         self.owner = None
         self.group = None
 

distutils/tests/test_sdist.py

@@ -270,7 +270,7 @@ def test_metadata_check_option(self, caplog):
         caplog.clear()
         dist, cmd = self.get_cmd()
         cmd.ensure_finalized()
-        cmd.metadata_check = 0
+        cmd.metadata_check = False
         cmd.run()
         assert len(self.warnings(caplog.messages, 'warning: check: ')) == 0