Skip to content

Commit 55f3b24

Browse files
committed
Use lower case for submitter role
Signed-off-by: Martin Vrachev <[email protected]>
1 parent 8939292 commit 55f3b24

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

tests/unit/email/test_init.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1143,14 +1143,14 @@ def test_removed_project_email_to_maintainer(
11431143
assert result == {
11441144
"project": "test_project",
11451145
"submitter": stub_submitter_user.username,
1146-
"submitter_role": "Owner",
1146+
"submitter_role": "owner",
11471147
"recipient_role_descr": "a maintainer",
11481148
}
11491149

11501150
subject_renderer.assert_(project="test_project")
11511151
body_renderer.assert_(project="test_project")
11521152
body_renderer.assert_(submitter=stub_submitter_user.username)
1153-
body_renderer.assert_(submitter_role="Owner")
1153+
body_renderer.assert_(submitter_role="owner")
11541154
body_renderer.assert_(recipient_role_descr="a maintainer")
11551155

11561156
assert pyramid_request.task.calls == [
@@ -1235,14 +1235,14 @@ def test_removed_project_email_to_owner(
12351235
assert result == {
12361236
"project": "test_project",
12371237
"submitter": stub_submitter_user.username,
1238-
"submitter_role": "Owner",
1238+
"submitter_role": "owner",
12391239
"recipient_role_descr": "an owner",
12401240
}
12411241

12421242
subject_renderer.assert_(project="test_project")
12431243
body_renderer.assert_(project="test_project")
12441244
body_renderer.assert_(submitter=stub_submitter_user.username)
1245-
body_renderer.assert_(submitter_role="Owner")
1245+
body_renderer.assert_(submitter_role="owner")
12461246
body_renderer.assert_(recipient_role_descr="an owner")
12471247

12481248
assert pyramid_request.task.calls == [
@@ -1338,7 +1338,7 @@ def test_send_removed_project_release_email_to_maintainer(
13381338
"release": release.version,
13391339
"release_date": release.created.strftime("%Y-%m-%d"),
13401340
"submitter": stub_submitter_user.username,
1341-
"submitter_role": "Owner",
1341+
"submitter_role": "owner",
13421342
"recipient_role_descr": "a maintainer",
13431343
}
13441344

@@ -1348,7 +1348,7 @@ def test_send_removed_project_release_email_to_maintainer(
13481348
body_renderer.assert_(release="0.0.0")
13491349
body_renderer.assert_(release_date=release.created.strftime("%Y-%m-%d"))
13501350
body_renderer.assert_(submitter=stub_submitter_user.username)
1351-
body_renderer.assert_(submitter_role="Owner")
1351+
body_renderer.assert_(submitter_role="owner")
13521352
body_renderer.assert_(recipient_role_descr="a maintainer")
13531353

13541354
assert pyramid_request.task.calls == [
@@ -1442,7 +1442,7 @@ def test_send_removed_project_release_emai_to_owner(
14421442
"release": release.version,
14431443
"release_date": release.created.strftime("%Y-%m-%d"),
14441444
"submitter": stub_submitter_user.username,
1445-
"submitter_role": "Owner",
1445+
"submitter_role": "owner",
14461446
"recipient_role_descr": "an owner",
14471447
}
14481448

@@ -1452,7 +1452,7 @@ def test_send_removed_project_release_emai_to_owner(
14521452
body_renderer.assert_(release="0.0.0")
14531453
body_renderer.assert_(release_date=release.created.strftime("%Y-%m-%d"))
14541454
body_renderer.assert_(submitter=stub_submitter_user.username)
1455-
body_renderer.assert_(submitter_role="Owner")
1455+
body_renderer.assert_(submitter_role="owner")
14561456
body_renderer.assert_(recipient_role_descr="an owner")
14571457

14581458
assert pyramid_request.task.calls == [

warehouse/email/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ def send_removed_project_email(
224224
return {
225225
"project": project_name,
226226
"submitter": submitter_name,
227-
"submitter_role": submitter_role,
227+
"submitter_role": submitter_role.lower(),
228228
"recipient_role_descr": recipient_role_descr,
229229
}
230230

@@ -242,7 +242,7 @@ def send_removed_project_release_email(
242242
"release": release.version,
243243
"release_date": release.created.strftime("%Y-%m-%d"),
244244
"submitter": submitter_name,
245-
"submitter_role": submitter_role,
245+
"submitter_role": submitter_role.lower(),
246246
"recipient_role_descr": recipient_role_descr,
247247
}
248248

0 commit comments

Comments
 (0)