Allow moderators to perform project ownership transfers (#9378)

Specifically adding and removing users with any role

Author: Yeray Diaz Diaz

warehouse/admin/templates/admin/projects/detail.html

@@ -124,7 +124,7 @@ <h4>Maintainers:</h4>
                   <td><a href="{{ request.route_path('admin.user.detail', user_id=role.user.id) }}">{{ role.user.username }}</a></td>
                   <td>{{ role.role_name }}</td>
                   <td>
-                    <button type="button" class="btn-danger btn-sm" data-toggle="modal" data-target="#deleteRoleModal-{{ role.id }}" {{ "disabled" if not request.has_permission('admin') }}>
+                    <button type="button" class="btn-danger btn-sm" data-toggle="modal" data-target="#deleteRoleModal-{{ role.id }}" {{ "disabled" if not request.has_permission('moderator') }}>
                       <i class="fa fa-trash"></i>
                     </button>
                     <div class="modal fade" id="deleteRoleModal-{{ role.id }}" tabindex="-1" role="dialog">
@@ -163,10 +163,10 @@ <h4 class="modal-title" id="exampleModalLabel">Remove role for {{ role.user.user
                   <form method="POST" action="{{ request.route_path('admin.project.add_role', project_name=project.name) }}">
                   <input name="csrf_token" type="hidden" value="{{ request.session.get_csrf_token() }}">
                   <td>
-                    <input name="username" class="form-control" placeholder="Username" required {{ "disabled" if not request.has_permission('admin') }}>
+                    <input name="username" class="form-control" placeholder="Username" required {{ "disabled" if not request.has_permission('moderator') }}>
                   </td>
                   <td>
-                    <select class="form-control" name="role_name" required {{ "disabled" if not request.has_permission('admin') }}>
+                    <select class="form-control" name="role_name" required {{ "disabled" if not request.has_permission('moderator') }}>
                       <option disabled selected>Select a role</option>
                       {% for role_name in ['Maintainer', 'Owner'] %}
                       <option value="{{ role_name }}">
@@ -176,7 +176,7 @@ <h4 class="modal-title" id="exampleModalLabel">Remove role for {{ role.user.user
                     </select>
                   </td>
                   <td>
-                    <button type="submit" class="btn btn-primary btn-sm" {{ "disabled" if not request.has_permission('admin') }}>
+                    <button type="submit" class="btn btn-primary btn-sm" {{ "disabled" if not request.has_permission('moderator') }}>
                       <i class="fa fa-plus"></i>
                     </button>
                   </td>

warehouse/admin/views/projects.py

@@ -337,7 +337,7 @@ def set_total_size_limit(project, request):
 
 @view_config(
     route_name="admin.project.add_role",
-    permission="admin",
+    permission="moderator",
     request_method="POST",
     uses_session=True,
     require_methods=False,
@@ -408,7 +408,7 @@ def add_role(project, request):
 
 @view_config(
     route_name="admin.project.delete_role",
-    permission="admin",
+    permission="moderator",
     request_method="POST",
     uses_session=True,
     require_methods=False,