make sure we don't double tap maintainers

if someone has a direct Role and a TeamRole we don't want to bother them twice

Author: ewdurbin

tests/unit/forklift/test_legacy.py

@@ -3761,6 +3761,8 @@ def test_egg_upload_sends_pep_715_notice_org_roles(
         )
         team = TeamFactory.create(organization=org)
         TeamRoleFactory.create(team=team, user=org_member)
+        # Duplicate the role directly on the project to ensure only one email
+        RoleFactory.create(user=org_member, project=project, role_name="Maintainer")
         TeamProjectRoleFactory.create(project=project, team=team)
 
         pyramid_config.testing_securitypolicy(identity=user)

warehouse/forklift/legacy.py

@@ -1483,7 +1483,7 @@ def file_upload(request):
             for teamrole in project.team_project_roles:
                 contributors += teamrole.team.members
 
-        for contributor in sorted(contributors):
+        for contributor in sorted(set(contributors)):
             send_egg_uploads_deprecated_email(
                 request,
                 contributor,

warehouse/packaging/tasks.py

@@ -530,7 +530,7 @@ def send_pep_715_notices(request):
             for teamrole in project.team_project_roles:
                 contributors += teamrole.team.members
 
-        for contributor in sorted(contributors):
+        for contributor in sorted(set(contributors)):
             send_egg_uploads_deprecated_initial_email(
                 request,
                 contributor,