-
Notifications
You must be signed in to change notification settings - Fork 1k
Improve the "download files" table #10448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The code which generates DOM markup is here https://github.com/pypa/warehouse/blob/5c78122a57257a2e76fe883d78500416784d6111/warehouse/templates/packaging/detail.html#L313 but I am not sure where to add the JS that will add the sorting behavior. I would also separate sources from binary wheels into separate tables and provided links to the same info exposed as JSON. |
Maybe because up to now the pages have no javascript. This may be a design decision, to support users without javascript. In this case those users would not be able to reorder the table. I am not a front-end dev, so I can only cheer from the sidelines, but maybe a start would be to propose reformatting the page. A subsequent task might be to add javascript for row ordering. |
I had a similar situation. I completely agree with Mattip. It will better if the table is sorted out according to headers. |
That's some 4x4 drive packages for |
Yes, it's valid, this is a 'compressed tag set': https://www.python.org/dev/peps/pep-0425/#compressed-tag-sets |
Regarding @mattip's original issue: I'm doubtful that displaying the various tags (in addition to the filename) would actually be helpful for the average user here. I think anyone that's aware of what a ABI/Platform tag is could get this same information from the filename. A better approach would be using these tags to create more human-friendly labels for each file, similar to what @tiran suggests in #10308 (and then making these filterable in the UI). Regarding @nedbat's comment, I agree that this UI doesn't handle long filenames well right now. I think #10646 should resolve it. |
Agreed that #10646 is a good step forward. |
#10646 does a good thing by separating sources and binaries, but it actually makes it harder to scan for necessary info. The good UX fix is multilevel table with necessary platform filters. An alternative #10646 is to contract long filenames dynamically as I could show how it may look like after #10469 is merged. |
xref #9066 |
What's the problem this feature will solve?
The list of downloads for a project like numpy is hard to navigate. The layout looks like
It can be difficult to find the proper file in the list.
Describe the solution you'd like
If desired, the current table could be added as well but hidden behind a css-fold (is that what this is called?) like
Complete listing
Additional context
Thanks!
The text was updated successfully, but these errors were encountered: