Localise JS strings

[nlhkabu]

Now that we have l10n support, we need to review our JS files and mark any strings for translation.

[woodruffw]

I believe this is out of scope for the OTF work -- we scoped for localizing views and templates, localizing JS will require is to construct a separate (probably client-side) localization system and ensure that the two don't fight.

IMPO, the right approach here is to audit the JS for English strings and remove them entirely (either by moving functionality to the backend or by returning error codes/hitting a renderer somehow to signal which string to display). That would avoid the need for two separate localization systems, and probably wouldn't involve any substantial changes (from what I've seen, there are relatively few English strings in the JS).

[miketheman]

The only strings in JS files I was able to identify as of hash 17f76cf live in these locations:

• warehouse/warehouse/static/js/warehouse/controllers/clipboard_controller.js

  Line 31 in 17f76cf

  this.tooltipTarget.dataset.clipboardTooltipValue = "Copied";

• warehouse/warehouse/static/js/warehouse/controllers/password_match_controller.js

  Line 31 in 17f76cf

  this.matchMessageTarget.textContent = "Passwords match";

• warehouse/warehouse/static/js/warehouse/controllers/password_match_controller.js

  Line 35 in 17f76cf

  this.matchMessageTarget.textContent = "Passwords do not match";

• warehouse/warehouse/static/js/warehouse/controllers/password_strength_gauge_controller.js

  Line 26 in 17f76cf

  this.setScreenReaderMessage("Password field is empty");

• warehouse/warehouse/static/js/warehouse/controllers/password_strength_gauge_controller.js

  Line 34 in 17f76cf

  this.setScreenReaderMessage(zxcvbnResult.feedback.suggestions.join(" ") || "Password is strong");

• warehouse/warehouse/static/js/warehouse/controllers/password_breach_controller.js

  Line 47 in 17f76cf

  const msg = "Error while validating hashed password, disregard on development";

• warehouse/warehouse/static/js/warehouse/utils/timeago.js

  Line 31 in 17f76cf

  return numDays == 1 ? "Yesterday" : `About ${numDays} days ago`;

• warehouse/warehouse/static/js/warehouse/utils/timeago.js

  Lines 35 to 41 in 17f76cf

  	numHours = numHours != 1 ? `${numHours} hours` : "an hour";
  	return `About ${numHours} ago`;
  	} else if (numMinutes > 0) {
  	numMinutes = numMinutes > 1 ? `${numMinutes} minutes` : "a minute";
  	return `About ${numMinutes} ago`;
  	} else {
  	return "Just now";

Most are trivial, and could potentially be localized from existing resources, leveraging https://www.i18next.com/ or similar.

[di]

https://github.com/guillaumepotier/gettext.js might also be a good option here.

[cofiem]

Most of these have been addressed by merging #15612 (except for the password strength phrases which are tricky to translate due to being mixed with zxcvbn output).

[miketheman]

Thanks for pushing through all that, @cofiem !

I think we're fine with not worrying too much about the messages from zxcvbn - if we want to go that route, we might need to look at migrating to the more recent zxcvbn-ts that has multi-language support.