linting

Author: bubenkoff

pytest_cloud/patches.py

@@ -41,10 +41,10 @@ def activate_env(channel, virtualenv_path, develop_eggs=None):
     :param develop_eggs: optional list of python packages to be installed in develop mode
     :type develop_eggs: list
     """
-    import os.path  # pylint: disable=W0404
-    import sys  # pylint: disable=W0404
-    import subprocess  # pylint: disable=W0404
-    from itertools import chain  # pylint: disable=W0404
+    import os.path  # pylint: disable=W0404,C0415
+    import sys  # pylint: disable=W0404,C0415
+    import subprocess  # pylint: disable=W0404,C0415
+    from itertools import chain  # pylint: disable=W0404,C0415
     py3 = sys.version_info[0] > 2
     subprocess.check_call(['find', '.', '-name', '*.pyc', '-delete'])
     if virtualenv_path:

pytest_cloud/plugin.py

@@ -29,7 +29,7 @@
 from . import patches
 
 
-# pylint: disable=R0903
+# pylint: disable=R0903,R0205
 class CloudXdistPlugin(object):
     """Plugin class to defer pytest-xdist hook handler."""
 
@@ -43,13 +43,26 @@ def pytest_configure(config):
         config.pluginmanager.register(CloudXdistPlugin())
 
 
+# pylint: disable=W0105
+def _ensure_value(namespace, name, value):
+    """Ensure value in the namespace. Copied from older version of argparse as is."""
+    if getattr(namespace, name, None) is None:
+        setattr(namespace, name, value)
+    return getattr(namespace, name)
+
+
 # pylint: disable=R0903
 class NodesAction(argparse.Action):
     """Parses out a space-separated list of nodes and extends dest with it."""
 
     def __call__(self, parser, namespace, values, option_string=None):
         """Parse out space-separated list of nodes."""
-        items = argparse._copy.copy(argparse._ensure_value(namespace, self.dest, []))
+        if not hasattr(argparse, "_copy_items"):
+            # pylint: disable=E1101
+            copy = argparse._copy.copy
+        else:
+            copy = argparse._copy_items
+        items = copy(_ensure_value(namespace, self.dest, []))
         items.extend([value.strip() for value in values.split()])
         setattr(namespace, self.dest, items)
 
@@ -130,7 +143,7 @@ def get_node_capabilities(channel):
     :return: `dict` in form {'cpu_count': 1, 'virtual_memory': {'available': 100, 'total': 200}}
     :rtype: dict
     """
-    import psutil
+    import psutil  # pylint: disable=C0415
     memory = psutil.virtual_memory()
     caps = dict(cpu_count=psutil.cpu_count(), virtual_memory=dict(available=memory.available, total=memory.total))
     channel.send(caps)

pytest_cloud/rsync.py

@@ -26,7 +26,7 @@ def make_reltoroot(roots, args):
     return res
 
 
-# pylint: disable=R0902
+# pylint: disable=R0902,R0205
 class RSync(object):
     """Send a directory structure (recursively) to one or multiple remote filesystems."""
 

tests/test_plugin.py

@@ -46,7 +46,7 @@ def dic():
         return {}
 
     def rep():
-        # pylint: disable=R0903
+        # pylint: disable=R0903,R0205
         class Report(object):
             skipped = []
             call = []
@@ -156,6 +156,7 @@ def test_schedule(
         params.append('--cloud-mem-per-process={0}'.format(mem_per_process))
     if max_processes:
         params.append('--cloud-max-processes={0}'.format(max_processes))
+
     testdir.inline_run(*params)
     assert mocked_rsync.call_args[0] == (testdir.tmpdir, 'test')
     assert mocked_rsync.return_value.add_target_host.call_args_list == [