Factor out _capturing_for_request into a function

Author: blueyed

src/_pytest/capture.py

@@ -148,34 +148,6 @@ def read_global_capture(self):
 
     # Fixture Control (it's just forwarding, think about removing this later)
 
-    @contextlib.contextmanager
-    def _capturing_for_request(
-        self, request: FixtureRequest
-    ) -> Generator["CaptureFixture", None, None]:
-        """
-        Context manager that creates a ``CaptureFixture`` instance for the
-        given ``request``, ensuring there is only a single one being requested.
-
-        This is used has a helper with ``capsys``, ``capfd`` etc.
-        """
-        if self._capture_fixture:
-            other_name = next(
-                k
-                for k, v in map_fixname_class.items()
-                if v is self._capture_fixture.captureclass
-            )
-            raise request.raiseerror(
-                "cannot use {} and {} at the same time".format(
-                    request.fixturename, other_name
-                )
-            )
-        capture_class = map_fixname_class[request.fixturename]
-        self._capture_fixture = CaptureFixture(capture_class, request)
-        self.activate_fixture()
-        yield self._capture_fixture
-        self._capture_fixture.close()
-        self._capture_fixture = None
-
     def activate_fixture(self):
         """If the current item is using ``capsys`` or ``capfd``, activate them so they take precedence over
         the global capture.
@@ -262,6 +234,36 @@ def pytest_internalerror(self, excinfo):
         self.stop_global_capturing()
 
 
+@contextlib.contextmanager
+def _capturing_for_request(
+    request: FixtureRequest,
+) -> Generator["CaptureFixture", None, None]:
+    """
+    Context manager that creates a ``CaptureFixture`` instance for the
+    given ``request``, ensuring there is only a single one being requested.
+
+    This is used has a helper with ``capsys``, ``capfd`` etc.
+    """
+    capman = request.config.pluginmanager.getplugin("capturemanager")
+    if capman._capture_fixture:
+        other_name = next(
+            k
+            for k, v in map_fixname_class.items()
+            if v is capman._capture_fixture.captureclass
+        )
+        raise request.raiseerror(
+            "cannot use {} and {} at the same time".format(
+                request.fixturename, other_name
+            )
+        )
+    capture_class = map_fixname_class[request.fixturename]
+    capman._capture_fixture = CaptureFixture(capture_class, request)
+    capman.activate_fixture()
+    yield capman._capture_fixture
+    capman._capture_fixture.close()
+    capman._capture_fixture = None
+
+
 @pytest.fixture
 def capsys(request):
     """Enable text capturing of writes to ``sys.stdout`` and ``sys.stderr``.
@@ -270,8 +272,7 @@ def capsys(request):
     calls, which return a ``(out, err)`` namedtuple.
     ``out`` and ``err`` will be ``text`` objects.
     """
-    capman = request.config.pluginmanager.getplugin("capturemanager")
-    with capman._capturing_for_request(request) as fixture:
+    with _capturing_for_request(request) as fixture:
         yield fixture
 
 
@@ -283,8 +284,7 @@ def capsysbinary(request):
     method calls, which return a ``(out, err)`` namedtuple.
     ``out`` and ``err`` will be ``bytes`` objects.
     """
-    capman = request.config.pluginmanager.getplugin("capturemanager")
-    with capman._capturing_for_request(request) as fixture:
+    with _capturing_for_request(request) as fixture:
         yield fixture
 
 
@@ -300,8 +300,7 @@ def capfd(request):
         pytest.skip(
             "capfd fixture needs os.dup function which is not available in this system"
         )
-    capman = request.config.pluginmanager.getplugin("capturemanager")
-    with capman._capturing_for_request(request) as fixture:
+    with _capturing_for_request(request) as fixture:
         yield fixture
 
 
@@ -317,8 +316,7 @@ def capfdbinary(request):
         pytest.skip(
             "capfdbinary fixture needs os.dup function which is not available in this system"
         )
-    capman = request.config.pluginmanager.getplugin("capturemanager")
-    with capman._capturing_for_request(request) as fixture:
+    with _capturing_for_request(request) as fixture:
         yield fixture