Skip to content

Commit 7e06d44

Browse files
committed
Fix -vv overriding --durations-min (#12938)
1 parent e8c2082 commit 7e06d44

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

Diff for: AUTHORS

+1
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,7 @@ Joseph Hunkeler
225225
Joseph Sawaya
226226
Josh Karpel
227227
Joshua Bronson
228+
Julian Valentin
228229
Jurko Gospodnetić
229230
Justice Ndou
230231
Justyna Janczyszyn

Diff for: changelog/12938.bugfix.rst

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fixed ``--durations-min`` argument not respected if ``-vv`` is used.

Diff for: src/_pytest/runner.py

+11-3
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def pytest_addoption(parser: Parser) -> None:
6161
"--durations-min",
6262
action="store",
6363
type=float,
64-
default=0.005,
64+
default=None,
6565
metavar="N",
6666
help="Minimal duration in seconds for inclusion in slowest list. "
6767
"Default: 0.005.",
@@ -74,6 +74,8 @@ def pytest_terminal_summary(terminalreporter: TerminalReporter) -> None:
7474
verbose = terminalreporter.config.get_verbosity()
7575
if durations is None:
7676
return
77+
if durations_min is None:
78+
durations_min = 0.005 if verbose < 2 else 0.0
7779
tr = terminalreporter
7880
dlist = []
7981
for replist in tr.stats.values():
@@ -90,10 +92,16 @@ def pytest_terminal_summary(terminalreporter: TerminalReporter) -> None:
9092
dlist = dlist[:durations]
9193

9294
for i, rep in enumerate(dlist):
93-
if verbose < 2 and rep.duration < durations_min:
95+
if rep.duration < durations_min:
9496
tr.write_line("")
9597
tr.write_line(
96-
f"({len(dlist) - i} durations < {durations_min:g}s hidden. Use -vv to show these durations.)"
98+
f"({len(dlist) - i} durations < {durations_min:g}s hidden."
99+
+ (
100+
" Use -vv to show these durations."
101+
if terminalreporter.config.option.durations_min is None
102+
else ""
103+
)
104+
+ ")"
97105
)
98106
break
99107
tr.write_line(f"{rep.duration:02.2f}s {rep.when:<8} {rep.nodeid}")

0 commit comments

Comments
 (0)