Update rm_rf function to force remove directories #13270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tusenka
approved these changes
Mar 18, 2025
Tusenka
reviewed
Mar 18, 2025
| else: | ||
| shutil.rmtree(str(path), onerror=onerror) | ||
| """Force remove directory even if it's not empty.""" | ||
| for root, dirs, files in os.walk(path, topdown=False): |
RonnyPfannschmidt
requested changes
Mar 18, 2025
| for file in files: | ||
| os.remove(os.path.join(root, file)) | ||
| for dir in dirs: | ||
| shutil.rmtree(os.path.join(root, dir), ignore_errors=True) |
There was a problem hiding this comment.
Ignoring errors doesn't imply success, it's just hiding the mess.
The-Compiler
requested changes
Mar 26, 2025
There was a problem hiding this comment.
shutil.rmtree can remove an non-empty directory recursively (that's its whole point over os.rmdir!). So here you're doing the same thing as before, but just with more manual work and simply hiding instead of reporting errors. As already pointed out, that's not a suitable approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13269
In previous
rm_rffunction Usesshutil.rmtree(path, onerror=onerror), which recursively deletes everything, handling errors via onerror.Now i update the
rm_rffunction to Explicitly walks the directory tree bottom-up(topdown=False)and removes files first, then subdirectories before deleting the main directory.Now there are no more warnings after passing all tests.