refactor: address part of the comments

Author: ali-bahjati

Diff for: apps/price_pusher/src/evm/evm.ts

@@ -435,18 +435,16 @@ export class EvmPricePusher implements IPricePusher {
         hash: hash,
       });
 
-      if (receipt.status === "success") {
-        this.logger.info({ hash }, "Price update successful");
-      } else if (receipt.status === "reverted") {
-        this.logger.info(
-          { hash, receipt },
-          "Price update reverted or its transaction did not land. " +
-            "This is an expected behaviour in high frequency or multi-instance setup."
-        );
-      } else {
-        throw new Error(
-          "This codepath should be unreachable. Please file a bug report."
-        );
+      switch (receipt.status) {
+        case "success":
+          this.logger.info({ hash }, "Price update successful");
+          break;
+        default:
+          this.logger.info(
+            { hash, receipt },
+            "Price update did not succeed or its transaction did not land. " +
+              "This is an expected behaviour in high frequency or multi-instance setup."
+          );
       }
     } catch (err: any) {
       this.logger.warn({ err }, "Failed to get transaction receipt");

Diff for: apps/price_pusher/src/utils.ts

@@ -18,12 +18,11 @@ export function removeLeading0x(id: HexString): HexString {
   return id;
 }
 
-export function addLeading0x(id: HexString): `0x${string}` {
-  if (id.startsWith("0x")) {
-    return id as `0x${string}`;
-  }
-  return ("0x" + id) as `0x${string}`;
-}
+export const addLeading0x = (id: HexString): `0x${string}` =>
+  hasLeading0x(id) ? id : `0x${id}`;
+
+const hasLeading0x = (input: string): input is `0x${string}` =>
+  input.startsWith("0x");
 
 export function isWsEndpoint(endpoint: string): boolean {
   const url = new URL(endpoint);