Skip to content

Commit 5f3aeba

Browse files
committed
add comments and make methods private
1 parent d0dab50 commit 5f3aeba

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

adaptive/learner/average_mixin.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,14 @@ def data_sem(self):
2626
def mean_values_per_point(self):
2727
return np.mean([x.n for x in self._data.values()])
2828

29-
def get_seed(self, point):
29+
def _next_seed(self, point):
3030
_data = self._data.get(point, {})
3131
pending_seeds = self.pending_points.get(point, set())
3232
seed = len(_data) + len(pending_seeds)
3333
if seed in _data or seed in pending_seeds:
34-
# means that the seed already exists, for example
34+
# Means that the seed already exists, for example
3535
# when '_data[point].keys() | pending_points[point] == {0, 2}'.
36+
# Only happens when starting the learner after cancelling/loading.
3637
return (set(range(seed)) - pending_seeds - _data.keys()).pop()
3738
return seed
3839

@@ -42,7 +43,7 @@ def loss_per_existing_point(self):
4243
points = []
4344
loss_improvements = []
4445
for p, sem in self.data_sem.items():
45-
points.append((p, self.get_seed(p)))
46+
points.append((p, self._next_seed(p)))
4647
N = self.n_values(p)
4748
sem_improvement = (1 - sqrt(N - 1) / sqrt(N)) * sem
4849
loss_improvement = self.weight * sem_improvement / scale
@@ -136,7 +137,7 @@ def _get_data(self):
136137

137138
def add_average_mixin(cls):
138139
names = ('data', 'data_sem', 'mean_values_per_point',
139-
'get_seed', 'loss_per_existing_point', '_add_to_pending',
140+
'_next_seed', 'loss_per_existing_point', '_add_to_pending',
140141
'_remove_from_to_pending', '_add_to_data', 'ask', 'n_values',
141142
'_normalize_new_points_loss_improvements',
142143
'_normalize_existing_points_loss_improvements',

0 commit comments

Comments
 (0)