Skip to content

documentation issues #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4 tasks
basnijholt opened this issue Mar 14, 2019 · 6 comments
Open
4 tasks

documentation issues #157

basnijholt opened this issue Mar 14, 2019 · 6 comments

Comments

@basnijholt
Copy link
Member

basnijholt commented Mar 14, 2019

@basnijholt
Copy link
Member Author

I don't think this can be fixed without releasing a new version.

@akhmerov
Copy link
Contributor

We should also somehow set it to refuse to build whenever an error is raised.

@basnijholt
Copy link
Member Author

We should also somehow set it to refuse to build whenever an error is raised.

I am not sure if this is possible because in the documentation we raise an error somewhere to show how to debug.

I propose an alternative in #169.

@akhmerov
Copy link
Contributor

We can incorporate this on the jupyter-sphinx side, see jupyter/jupyter-sphinx#25

@basnijholt
Copy link
Member Author

Yes, I agree that that would be a good solution, but not the full solution.

The reason why the docs were broken most recently (#168) wasn't because of an error but because of the fact that some javascript libs were loaded differently.

So I still think it is a good idea to be able to preview the docs somehow before merging.

@akhmerov
Copy link
Contributor

Right, absolutely. Both are important.

@basnijholt basnijholt changed the title documentation of stable is broken documentation issues Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants