-
Notifications
You must be signed in to change notification settings - Fork 58
documentation issues #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't think this can be fixed without releasing a new version. |
We should also somehow set it to refuse to build whenever an error is raised. |
I am not sure if this is possible because in the documentation we raise an error somewhere to show how to debug. I propose an alternative in #169. |
We can incorporate this on the jupyter-sphinx side, see jupyter/jupyter-sphinx#25 |
Yes, I agree that that would be a good solution, but not the full solution. The reason why the docs were broken most recently (#168) wasn't because of an error but because of the fact that some javascript libs were loaded differently. So I still think it is a good idea to be able to preview the docs somehow before merging. |
Right, absolutely. Both are important. |
The text was updated successfully, but these errors were encountered: