Skip to content

release 0.6.0 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
basnijholt opened this issue Dec 19, 2018 · 8 comments
Closed

release 0.6.0 #33

basnijholt opened this issue Dec 19, 2018 · 8 comments

Comments

@basnijholt
Copy link
Member

(original issue on GitLab)

opened by Bas Nijholt (@basnijholt) at 2018-09-24T16:59:55.276Z

Since 0.5.0 we fixed the following issues:

  • gitlab:#66: (refactor) learner.tell(x, None) might be renamed to learner.tell_pending(x)
  • gitlab:#92: DeprecationWarning: sorted_dict.iloc is deprecated. Use SortedDict.keys() instead.
  • gitlab:#94: Learner1D breaks if right bound is added before the left bound
  • gitlab:#95: Learner1D's bound check algo in self.ask doesn't take self.data or self.pending_points
  • gitlab:#96: Learner1D fails when function returns a list instead of a numpy.array
  • gitlab:#97: Learner1D fails when a point (x, None) is added when x already exists
  • gitlab:#98: Learner1D.ask breaks when adding points in some order
  • gitlab:#99: Learner1D doesn't correctly set the interpolated loss when a point is added
  • gitlab:#101: How should learners handle data that is outside of the domain
  • gitlab:#102: No tests for the 'BalancingLearner'
  • gitlab:#105: LearnerND fails for BalancingLearner test
  • gitlab:#108: (BalancingLearner) loss is cached incorrectly
  • gitlab:#109: Learner2D suggests same point twice

and merged the following Merge Requests:

  • gitlab:!93: add a release guide
  • gitlab:!94: add runner.max_retries
  • gitlab:!95: 1D: fix the rare case where the right boundary point exists before the left bound
  • gitlab:!96: More efficient 'tell_many'
  • gitlab:!97: Fix gitlab:#97 and gitlab:#98
  • gitlab:!98: Resolve "DeprecationWarning: sorted_dict.iloc is deprecated. Use SortedDict.keys() instead."
  • gitlab:!99: Resolve "Learner1D's bound check algo in self.ask doesn't take self.data or self.pending_points"
  • gitlab:!100: Resolve "Learner1D doesn't correctly set the interpolated loss when a point is added"
  • gitlab:!101: Resolve "Learner1D fails when function returns a list instead of a numpy.array"
  • gitlab:!102: introduce 'runner.retries' and 'runner.raise_if_retries_exceeded'
  • gitlab:!103: 2D: rename 'learner._interp' to 'learner.pending_points' as in other learners
  • gitlab:!104: Make the AverageLearner only return new points ...
  • gitlab:!105: move specific tests for a particular learner to separate files
  • gitlab:!107: Introduce 'tell_pending' which replaces 'tell(x, None)'
  • gitlab:!112: Resolve "LearnerND fails for BalancingLearner test"
  • gitlab:!113: Resolve "(BalancingLearner) loss is cached incorrectly"
  • gitlab:!114: update release guide to add a 'dev' tag on top of regular tags
  • gitlab:!115: Resolve "How should learners handle data that is outside of the domain"
  • gitlab:!116: 2D: fix gitlab:#109

New features

  • add learner.tell_pending which replaces learner.tell(x, None)
  • add error-handling with runner.retries and runner.raise_if_retries_exceeded
  • make learner.pending_points and runner.pending_points public API
  • rename learner.ask(n, add_data) -> learner.ask(n, tell_pending)
  • added the overhead method to the BlockingRunner

I think we should release 0.6.0 since we introduce some new features. @jbweston and @anton-akhmerov do you have a different opinion?

@basnijholt
Copy link
Member Author

originally posted by Anton Akhmerov (@anton-akhmerov) at 2018-09-24T18:32:38.668Z on GitLab

Because I'm on vacation, I'll abstain on this one. No objections from my side on releasing and version choice.

@basnijholt
Copy link
Member Author

originally posted by Jorn Hoofwijk (@Jorn) at 2018-09-25T10:41:35.189Z on GitLab

I would like the following to be merged as well:
gitlab:!112 gitlab:#105

Since this issue is actually much broader than just the balancingLearner + LearnerND, the problem is actually the combination of Async + LearnerND, which I suppose would occur often.

@basnijholt
Copy link
Member Author

originally posted by Joseph Weston (@jbweston) at 2018-09-25T11:26:39.995Z on GitLab

Seems like a good idea. I will triage the issues and MRs so we know what we still have to do before 0.6

@basnijholt
Copy link
Member Author

originally posted by Jorn Hoofwijk (@Jorn) at 2018-09-25T11:30:41.200Z on GitLab

Then maybe we can also add gitlab:!113 (gitlab:#108)

@basnijholt
Copy link
Member Author

originally posted by Joseph Weston (@jbweston) at 2018-09-25T11:31:55.318Z on GitLab

@jorn tag any issues and MRs with the v0.6 milestone (in the right-hand menu in Gitlab), i.e. please triage the issues and MRs (I said I would do this above, but you're probably better placed to do it).

@basnijholt
Copy link
Member Author

originally posted by Bas Nijholt (@basnijholt) at 2018-10-04T13:36:37.615Z on GitLab

All issues and merge requests for 0.6 have been closed and merged. Shall we do it now? @anton-akhmerov, @jorn, and @jbweston?

@basnijholt
Copy link
Member Author

originally posted by Joseph Weston (@jbweston) at 2018-10-04T13:37:34.422Z on GitLab

Great. Go for it

@basnijholt
Copy link
Member Author

originally posted by Jorn Hoofwijk (@Jorn) at 2018-10-05T08:56:51.941Z on GitLab

Agreed, think it is about right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant