Skip to content

Handling with regions unreachable inside the ConvexHull in LearnerND #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lsyxiaopang opened this issue Jun 23, 2023 · 2 comments
Closed

Comments

@lsyxiaopang
Copy link

This library is very cool and I've been using it for controlling measuring instruments. However, for measuring instruments, there would be some situations where one or more regions inside the range cannot reach, and the parameters of LearnerND cannot handle this problem.

So, is there any ways to solve this problem without affecting the library too much, for example, if I got point that I can't reach, I may just return 0.

Thank you!

@basnijholt
Copy link
Member

If you know these unreachable regions before hand, you could write a WrappedFunction around the function that controls your instrument. Then, if you are within those regions, you will simply return NaN.

@lsyxiaopang
Copy link
Author

If you know these unreachable regions before hand, you could write a WrappedFunction around the function that controls your instrument. Then, if you are within those regions, you will simply return NaN.

Thank you, I think these NaNs may not affect the predictions too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants