Skip to content

1D and 2D learner: stop interpolating function instead of the loss #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
basnijholt opened this issue Dec 19, 2018 · 0 comments
Closed

Comments

@basnijholt
Copy link
Member

(original issue on GitLab)

opened by Anton Akhmerov (@anton-akhmerov) at 2018-03-10T21:14:20.732Z

Right now as the user requests more points but does not provide any data, we update the learner's state by adding "fake" points with values interpolated using a linear approximation. In the cquad implementation we realized that this is conceptually not right, and instead we directly consider the loss of the children intervals a fraction of the parent loss.

Also in the 1D and 2D learner this would make more sense and would allow them to support arbitrary loss functions.

Related: gitlab:#50, gitlab:!34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant