Skip to content

Commit ff24885

Browse files
committed
update tests to reflect new unescaped-equal-signs-in-query-param-values regime (see #38).
1 parent 005e04d commit ff24885

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

Diff for: .tox-coveragerc

+2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ branch = True
33
source =
44
hyperlink
55
../hyperlink
6+
omit =
7+
*/flycheck_*
68

79
[paths]
810
source =

Diff for: hyperlink/test/test_url.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -542,12 +542,10 @@ def test_parseEqualSignInParamValue(self):
542542
"""
543543
u = URL.from_text('http://localhost/?=x=x=x')
544544
self.assertEqual(u.get(''), ['x=x=x'])
545-
# TODO: see #38
546-
# self.assertEqual(u.to_text(), 'http://localhost/?=x%3Dx%3Dx')
545+
self.assertEqual(u.to_text(), 'http://localhost/?=x=x=x')
547546
u = URL.from_text('http://localhost/?foo=x=x=x&bar=y')
548547
self.assertEqual(u.query, (('foo', 'x=x=x'), ('bar', 'y')))
549-
# TODO: see #38
550-
# self.assertEqual(u.to_text(), 'http://localhost/?foo=x%3Dx%3Dx&bar=y')
548+
self.assertEqual(u.to_text(), 'http://localhost/?foo=x=x=x&bar=y')
551549

552550
u = URL.from_text('https://example.com/?argument=3&argument=4&operator=%3D')
553551
iri = u.to_iri()

Diff for: tox.ini

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ envlist = py26,py27,py34,py35,py36,pypy,coverage-report,packaging
44
[testenv]
55
changedir = .tox
66
deps = -rrequirements-test.txt
7-
commands = coverage run --parallel --omit 'flycheck__*' --rcfile {toxinidir}/.tox-coveragerc -m pytest --doctest-modules {envsitepackagesdir}/hyperlink {posargs}
7+
commands = coverage run --parallel --rcfile {toxinidir}/.tox-coveragerc -m pytest --doctest-modules {envsitepackagesdir}/hyperlink {posargs}
88

99
# Uses default basepython otherwise reporting doesn't work on Travis where
1010
# Python 3.6 is only available in 3.6 jobs.

0 commit comments

Comments
 (0)