Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: python-lsp/python-lsp-jsonrpc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.1.1
Choose a base ref
...
head repository: python-lsp/python-lsp-jsonrpc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: develop
Choose a head ref
  • 3 commits
  • 6 files changed
  • 3 contributors

Commits on Sep 23, 2023

  1. Fix tests so they're compatible with both ujson and pure json library (

    …#26)
    
    Co-authored-by: Andrew Johnston <[email protected]>
    ajohnston9 and Andrew Johnston authored Sep 23, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    869bf81 View commit details
  2. Copy the full SHA
    786d8dd View commit details

Commits on Aug 14, 2024

  1. Update action versions used on CIs (#30)

    ccordoba12 authored Aug 14, 2024
    Copy the full SHA
    eab2610 View commit details
Showing with 37 additions and 26 deletions.
  1. +3 −6 .github/workflows/static.yml
  2. +3 −4 .github/workflows/test-linux.yml
  3. +4 −5 .github/workflows/test-mac.yml
  4. +3 −4 .github/workflows/test-win.yml
  5. +10 −0 CHANGELOG.md
  6. +14 −7 test/test_streams.py
9 changes: 3 additions & 6 deletions .github/workflows/static.yml
Original file line number Diff line number Diff line change
@@ -18,19 +18,16 @@ jobs:
OS: 'linux'
timeout-minutes: 2
steps:
- uses: actions/cache@v1
- uses: actions/cache@v4
with:
path: ~/.cache/pip
key: static-pip-${{ hashFiles('setup.py') }}
restore-keys: static-pip-
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
# TODO: check with Python 3, but need to fix the
# errors first
python-version: '3.8'
architecture: 'x64'
- run: python -m pip install --upgrade pip setuptools
- run: pip install -e .[test]
- name: Pylint checks
run: pylint pylsp_jsonrpc test
7 changes: 3 additions & 4 deletions .github/workflows/test-linux.yml
Original file line number Diff line number Diff line change
@@ -23,17 +23,16 @@ jobs:
PYTHON_VERSION: ['3.10', '3.9', '3.8']
timeout-minutes: 10
steps:
- uses: actions/cache@v1
- uses: actions/cache@v4
with:
path: ~/.cache/pip
key: ${{ runner.os }}-${{ matrix.PYTHON_VERSION }}-pip-${{ hashFiles('setup.py') }}
restore-keys: ${{ runner.os }}-${{ matrix.PYTHON_VERSION }}-pip-
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.PYTHON_VERSION }}
architecture: 'x64'
- run: python -m pip install --upgrade pip setuptools
- run: pip install -e .[all,test]
- run: pytest -v test/
# Enable this if SSH debugging is required
9 changes: 4 additions & 5 deletions .github/workflows/test-mac.yml
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@ on:
jobs:
build:
name: Mac Py${{ matrix.PYTHON_VERSION }}
runs-on: macos-latest
runs-on: macos-13
env:
CI: 'true'
OS: 'macos'
@@ -23,17 +23,16 @@ jobs:
PYTHON_VERSION: ['3.10', '3.9', '3.8']
timeout-minutes: 10
steps:
- uses: actions/cache@v1
- uses: actions/cache@v4
with:
path: ~/Library/Caches/pip
key: ${{ runner.os }}-${{ matrix.PYTHON_VERSION }}-pip-${{ hashFiles('setup.py') }}
restore-keys: ${{ runner.os }}-${{ matrix.PYTHON_VERSION }}-pip-
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.PYTHON_VERSION }}
architecture: 'x64'
- run: python -m pip install --upgrade pip setuptools
- run: pip install -e .[all,test]
- run: pytest -v test/
# Enable this if SSH debugging is required
7 changes: 3 additions & 4 deletions .github/workflows/test-win.yml
Original file line number Diff line number Diff line change
@@ -23,16 +23,15 @@ jobs:
PYTHON_VERSION: ['3.10', '3.9', '3.8']
timeout-minutes: 10
steps:
- uses: actions/cache@v1
- uses: actions/cache@v4
with:
path: ~\AppData\Local\pip\Cache
key: ${{ runner.os }}-${{ matrix.PYTHON_VERSION }}-pip-${{ hashFiles('setup.py') }}
restore-keys: ${{ runner.os }}-${{ matrix.PYTHON_VERSION }}-pip-
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.PYTHON_VERSION }}
architecture: 'x64'
- run: python -m pip install --upgrade pip setuptools
- run: pip install -e .[all,test]
- run: pytest -v test/
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
# History of changes

## Version 1.1.2 (2023/09/23)

### Pull Requests Merged

* [PR 26](https://github.com/python-lsp/python-lsp-jsonrpc/pull/26) - Fix tests so they're compatible with both ujson and pure json library, by [@ajohnston9](https://github.com/ajohnston9)

In this release 1 pull request was closed.

----

## Version 1.1.1 (2023/09/09)

### Issues Closed
21 changes: 14 additions & 7 deletions test/test_streams.py
Original file line number Diff line number Diff line change
@@ -82,13 +82,20 @@ def test_writer(wfile, writer):
'method': 'method',
'params': {}
})

assert wfile.getvalue() == (
b'Content-Length: 44\r\n'
b'Content-Type: application/vscode-jsonrpc; charset=utf8\r\n'
b'\r\n'
b'{"id":"hello","method":"method","params":{}}'
)
if 'ujson' in sys.modules:
assert wfile.getvalue() == (
b'Content-Length: 44\r\n'
b'Content-Type: application/vscode-jsonrpc; charset=utf8\r\n'
b'\r\n'
b'{"id":"hello","method":"method","params":{}}'
)
else:
assert wfile.getvalue() == (
b'Content-Length: 49\r\n'
b'Content-Type: application/vscode-jsonrpc; charset=utf8\r\n'
b'\r\n'
b'{"id": "hello", "method": "method", "params": {}}'
)


class JsonDatetime(datetime.datetime):