Skip to content

Add support for pyflakes 3.1 #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yan12125 opened this issue Aug 6, 2023 · 3 comments · Fixed by #415
Closed

Add support for pyflakes 3.1 #412

yan12125 opened this issue Aug 6, 2023 · 3 comments · Fixed by #415
Labels
enhancement New feature or request
Milestone

Comments

@yan12125
Copy link
Contributor

yan12125 commented Aug 6, 2023

pyflakes 3.1.0 was released a few days ago with Python 3.12 support and various other fixes/improvements [1]. Could you consider bumping version constraints for pyflakes [2]?

I tried removing the upper bound for pyflakes and use it with the latest pyflakes, but no warnings/errors are reported. I guess the issue is that ContinueInFinally is dropped from pyflakes [3], while python-lsp-server still tries to use it [4]. If I removed the line at [4], pyflakes 3.1 works fine with python-lsp-server.

[1] https://github.com/PyCQA/pyflakes/blob/3.1.0/NEWS.rst
[2] https://github.com/python-lsp/python-lsp-server/blob/v1.7.4/pyproject.toml#L35
[3] PyCQA/pyflakes#752
[4] https://github.com/python-lsp/python-lsp-server/blob/v1.7.4/pylsp/plugins/pyflakes_lint.py#L18

@ccordoba12
Copy link
Member

Hey @yan12125, thanks for reporting. We can't update to that Pyflakes version before Flake8 adds support for it because we also support Flake8.

So, let us know when that happens and we'll be able to do it.

@yan12125
Copy link
Contributor Author

yan12125 commented Aug 9, 2023

Hi, flake8 6.1.0 has updated Pyflakes to >= 3.1.0, < 3.2.0 [1]. I think that is no longer a blocker?

[1] https://flake8.pycqa.org/en/latest/release-notes/6.1.0.html

@ccordoba12
Copy link
Member

Correct. We'll address this in our next version then.

@ccordoba12 ccordoba12 added this to the v1.8.0 milestone Aug 9, 2023
@ccordoba12 ccordoba12 added the enhancement New feature or request label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants