Skip to content

notebookDocumentSync notebookSelector type error #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xueerli opened this issue Oct 8, 2023 · 2 comments · Fixed by #454
Closed

notebookDocumentSync notebookSelector type error #453

xueerli opened this issue Oct 8, 2023 · 2 comments · Fixed by #454
Labels
bug Something isn't working
Milestone

Comments

@xueerli
Copy link

xueerli commented Oct 8, 2023

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#notebookDocumentSyncOptions

The notebookSelector should be an array type. But now the object is returned.
image

@ccordoba12
Copy link
Member

Hey @xueerli, thanks for reporting. Although the LSP docs are not so clear about it, taking a look at the Python implementation of the protocol, I think you're right:

https://github.com/microsoft/lsprotocol/blob/3371f9ecc1b3ad952d9757c27562b3ea4dcc1381/packages/python/lsprotocol/types.py#L6709-L6740

https://github.com/microsoft/lsprotocol/blob/3371f9ecc1b3ad952d9757c27562b3ea4dcc1381/tests/python/test_cattrs_special_cases.py#L270-L280

@smacke, could you take a look at this one? Thanks!

@ccordoba12 ccordoba12 added this to the v1.8.2 milestone Oct 8, 2023
@smacke
Copy link
Contributor

smacke commented Oct 8, 2023

Looks like a bug; #454 should fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants