Skip to content

Don't enable services implicitly #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexppg opened this issue Mar 30, 2020 · 1 comment · Fixed by #107
Closed

Don't enable services implicitly #106

alexppg opened this issue Mar 30, 2020 · 1 comment · Fixed by #107
Assignees
Labels
bug Something isn't working

Comments

@alexppg
Copy link
Member

alexppg commented Mar 30, 2020

Describe the bug
A clear and concise description of what the bug is.
When you don't enable a service, it still may be loaded.
To Reproduce
Steps to reproduce the behavior:
Use the next config:

pyms:
  services:
    metrics: true
  config:
    debug: true
    app_name: alertmanager-actions
    testing: false

When receiving a request, it will return the next error:

Tracer error: 'NoneType' object has no attribute 'tracer'

Expected behavior
It should not return that error.

Additional context
I'm using pyms 2.4.1 version.

When disabling explicitly the service, it does not return the error:

pyms:
  services:
    metrics: true
    tracer:
      enabled: false
  config:
    debug: true
    app_name: alertmanager-actions
    testing: false
@avara1986 avara1986 linked a pull request Mar 30, 2020 that will close this issue
@avara1986 avara1986 added the bug Something isn't working label Mar 30, 2020
@avara1986 avara1986 self-assigned this Mar 30, 2020
@alexppg
Copy link
Member Author

alexppg commented Mar 30, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants