-
-
Notifications
You must be signed in to change notification settings - Fork 133
Multi-query parameter validation not working #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It must be something with the integration. I assume you use Falcon one? |
Yes, it's Falcon, little older version, |
In meantime, I migrated to the latest Following still working partially:
"Partially" because it failing if I pass only one parameter (in all other combinations it working fine). However, my question again is - why valid OpenAPI 3 description is not supported:
Falcon properly decodes such request, for example request
Am I missing something here? |
@p1c2u I apologize for making noise, but how can I properly describe multi-value query parameters in OpenAPI 3 spec so that it working fine with It must be that I'm doing something wrong, but not sure what!? |
I think I found the reason of this issue. I will prepare fix for that. |
Thanks a lot, Arthur, but it still doesn't work for me... I may be missing something, but is this OpenAPI spec snippet proper description for multi-value query parameters:
|
yes this looks correct. you can have a look at my test for the issue and compare. did you check master version? can you prepare minimal example? |
Oh man, I was looking at version Latest code from the Can you please tell me when we can expect official release with this fix? |
@p1c2u I apologize for disturbing one more time, can you please just let me know are there plans to release this fix in coming days or it may need some more time? Thanks in advance, appreciate your hard work as always. |
Validation for query parameter with multiple values (i.e. array values in form-style query expansion) not working, at least from version
0.13.3
ofopenapi-core
.Example request:
Appropriate OpenAPI spec to validate above parameters as
a = ['1', '2']
:Validation error:
Till version
0.13.8
it was possible to "cheat" validation by describing schema as:Unfortunately, above workaround not working anymore (from version
0.14.0
), but strangely, schema can be described as follows:However, this is not proper way to describe query parameter with multiple values and should be fixed!
The text was updated successfully, but these errors were encountered: