Skip to content

Missing QtWebKit/QtWebEngine modules #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
The-Compiler opened this issue Oct 28, 2019 · 11 comments
Closed

Missing QtWebKit/QtWebEngine modules #15

The-Compiler opened this issue Oct 28, 2019 · 11 comments

Comments

@The-Compiler
Copy link
Collaborator

Looks like the stubs for all the QtWebKit and QtWebEngine modules went missing.

@stlehmann
Copy link
Collaborator

Yes, PyQt5 doesn't provide them anymore when compiling so I sadly had to remove them at an early stage.

@The-Compiler
Copy link
Collaborator Author

Sorry for the late answer - PyQt5 definitely still has both of those. It looks more like your Qt didn't have them installed, so sip didn't build the .pyi files. I guess ideally we'd somehow get sip to spit out .pyi files without actually having to build the underlying C++ code, but not sure how realistic that is.

@BryceBeagle
Copy link
Collaborator

BryceBeagle commented Apr 20, 2020

On Ubuntu 18.04 I only get the the following .pyi files to generate:

  • QtCore.pyi
  • QtDBus.pyi
  • QtGui.pyi
  • QtNetwork.pyi
  • QtOpenGL.pyi
  • QtPrintSupport.pyi
  • QtSql.pyi
  • QtTest.pyi
  • QtWidgets.pyi
  • QtXml.pyi

But on Arch, with the same PyQt5 source tar, I get everything:

  • QtGui.pyi
  • QtNfc.pyi
  • QtQml.pyi
  • QtSql.pyi
  • QtSvg.pyi
  • QtXml.pyi
  • QtCore.pyi
  • QtDBus.pyi
  • QtHelp.pyi
  • QtTest.pyi
  • QtQuick.pyi
  • QtOpenGL.pyi
  • QtWebKit.pyi
  • QtNetwork.pyi
  • QtSensors.pyi
  • QtWidgets.pyi
  • QtDesigner.pyi
  • QtLocation.pyi
  • QtBluetooth.pyi
  • QtX11Extras.pyi
  • QtSerialPort.pyi
  • QtWebChannel.pyi
  • QtWebSockets.pyi
  • QtNetworkAuth.pyi
  • QtPositioning.pyi
  • QtXmlPatterns.pyi
  • QtPrintSupport.pyi
  • QtQuickWidgets.pyi
  • QtRemoteObjects.pyi
  • QtWebKitWidgets.pyi

@stlehmann
Copy link
Collaborator

That's interesting. So maybe we should adjust the Dockerfile to use Arch-Linux instead of Ubuntu. @BryceBeagle as you already got the build going on Arch would you mind adjusting the Dockerfile?

@stlehmann
Copy link
Collaborator

PyQt5 definitely still has both of those. It looks more like your Qt didn't have them installed, so sip didn't build the .pyi files.

That might be the case. In the buildenv Dockerfile I install Ubuntus qt5-default package. Do you know how to add QWebKit and QWebEngine on Ubuntu respectively Arch?

@BryceBeagle
Copy link
Collaborator

BryceBeagle commented Apr 21, 2020

Sure, I'd be glad to look into it.

However, I'm hesitant to use an Arch Linux-based Dockerfile because the distro doesn't make locking versions especially easy. Their repositories don't keep a very long history of packages so the Dockerfile would either need to manually modify PKGBUILDs, or just assume that the latest version of the software is always good enough.

I'll try to get an Ubuntu Dockerfile working, or maybe use something like Alpine, which still updates regularly but also keeps old versions of software, if that's alright with you?

@stlehmann
Copy link
Collaborator

Sure that would be great. 👍

@The-Compiler
Copy link
Collaborator Author

On Ubuntu 18.04 I only get the the following .pyi files to generate: [...]

Are you sure the underlying Qt modules (e.g. libqt5webengine5) are installed?

Their repositories don't keep a very long history of packages

They sure do! (the entire history)

@BryceBeagle
Copy link
Collaborator

Are you sure the underlying Qt modules (e.g. libqt5webengine5) are installed?

You're right, they weren't installed. I never manually installed them on Arch, but they were optional dependencies of python-pyqt5 that were pulled down

They sure do!

After 6 years of using Arch, how did I not know this existed? 🤦 Guess that shows how often I need to downgrade -- my local cache has always been good enough.

@BryceBeagle
Copy link
Collaborator

I opened PR #36 for this

@The-Compiler
Copy link
Collaborator Author

Closing this as #36 was merged - thanks @BryceBeagle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants