Skip to content

Commit 58308e3

Browse files
committed
fix(parser-scipy)!: remove release notice footer messages from commit descriptions
BREAKING CHANGE: Any release notice footer messages that the commit parser detects will now be removed from the `commit.descriptions[]` list but maintained in and only in the `commit.notices[]` list. Previously, the descriptions included all text from the commit message but that was redundant as the default changelog now handles release notice footers in its own section.
1 parent 7e8dc13 commit 58308e3

File tree

1 file changed

+2
-3
lines changed
  • src/semantic_release/commit_parser

1 file changed

+2
-3
lines changed

src/semantic_release/commit_parser/scipy.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -290,10 +290,9 @@ def commit_body_components_separator(
290290
notice := match.group("notice")
291291
):
292292
accumulator["notices"].append(notice)
293-
# TODO: breaking change v10, removes notice footers from descriptions
294-
# return accumulator
293+
return accumulator
295294

296-
elif match := self.issue_selector.search(text):
295+
if match := self.issue_selector.search(text):
297296
# if match := self.issue_selector.search(text):
298297
predicate = regexp(r",? and | *[,;/& ] *").sub(
299298
",", match.group("issue_predicate") or ""

0 commit comments

Comments
 (0)