Skip to content

Commit 0741da8

Browse files
authored
GH-90829: Fix empty iterable error message in min/max (#31181)
1 parent b034fd3 commit 0741da8

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

Lib/test/test_builtin.py

+10-2
Original file line numberDiff line numberDiff line change
@@ -1155,7 +1155,11 @@ def test_max(self):
11551155
max()
11561156

11571157
self.assertRaises(TypeError, max, 42)
1158-
self.assertRaises(ValueError, max, ())
1158+
with self.assertRaisesRegex(
1159+
ValueError,
1160+
r'max\(\) iterable argument is empty'
1161+
):
1162+
max(())
11591163
class BadSeq:
11601164
def __getitem__(self, index):
11611165
raise ValueError
@@ -1214,7 +1218,11 @@ def test_min(self):
12141218
min()
12151219

12161220
self.assertRaises(TypeError, min, 42)
1217-
self.assertRaises(ValueError, min, ())
1221+
with self.assertRaisesRegex(
1222+
ValueError,
1223+
r'min\(\) iterable argument is empty'
1224+
):
1225+
min(())
12181226
class BadSeq:
12191227
def __getitem__(self, index):
12201228
raise ValueError

Python/bltinmodule.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -1814,7 +1814,7 @@ min_max(PyObject *args, PyObject *kwds, int op)
18141814
maxitem = Py_NewRef(defaultval);
18151815
} else {
18161816
PyErr_Format(PyExc_ValueError,
1817-
"%s() arg is an empty sequence", name);
1817+
"%s() iterable argument is empty", name);
18181818
}
18191819
}
18201820
else

0 commit comments

Comments
 (0)