Skip to content

Commit 0dca261

Browse files
committed
add @critical_section to callers of set_hook
1 parent 089821e commit 0dca261

File tree

2 files changed

+15
-6
lines changed

2 files changed

+15
-6
lines changed

Modules/clinic/readline.c.h

Lines changed: 7 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Modules/readline.c

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -447,7 +447,7 @@ set_hook(const char *funcname, PyObject **hook_var, PyObject *function)
447447
}
448448

449449
/*[clinic input]
450-
@critical_section module
450+
@critical_section
451451
readline.set_completion_display_matches_hook
452452
453453
function: object = None
@@ -463,7 +463,7 @@ once each time matches need to be displayed.
463463
static PyObject *
464464
readline_set_completion_display_matches_hook_impl(PyObject *module,
465465
PyObject *function)
466-
/*[clinic end generated code: output=516e5cb8db75a328 input=5fddfa5edb69582c]*/
466+
/*[clinic end generated code: output=516e5cb8db75a328 input=ea4191e4a07d28d3]*/
467467
{
468468
readlinestate *state = get_readline_state(module);
469469
PyObject *result = set_hook("completion_display_matches_hook",
@@ -485,6 +485,7 @@ readline_set_completion_display_matches_hook_impl(PyObject *module,
485485
}
486486

487487
/*[clinic input]
488+
@critical_section
488489
readline.set_startup_hook
489490
490491
function: object = None
@@ -498,7 +499,7 @@ before readline prints the first prompt.
498499

499500
static PyObject *
500501
readline_set_startup_hook_impl(PyObject *module, PyObject *function)
501-
/*[clinic end generated code: output=02cd0e0c4fa082ad input=7783b4334b26d16d]*/
502+
/*[clinic end generated code: output=02cd0e0c4fa082ad input=11fce34992f1125e]*/
502503
{
503504
readlinestate *state = get_readline_state(module);
504505
return set_hook("startup_hook", &state->startup_hook,
@@ -510,6 +511,7 @@ readline_set_startup_hook_impl(PyObject *module, PyObject *function)
510511
/* Set pre-input hook */
511512

512513
/*[clinic input]
514+
@critical_section
513515
readline.set_pre_input_hook
514516
515517
function: object = None
@@ -524,7 +526,7 @@ characters.
524526

525527
static PyObject *
526528
readline_set_pre_input_hook_impl(PyObject *module, PyObject *function)
527-
/*[clinic end generated code: output=fe1a96505096f464 input=4f3eaeaf7ce1fdbe]*/
529+
/*[clinic end generated code: output=fe1a96505096f464 input=96d3d5ff4a0c7c28]*/
528530
{
529531
readlinestate *state = get_readline_state(module);
530532
return set_hook("pre_input_hook", &state->pre_input_hook,
@@ -800,6 +802,7 @@ readline_get_completer_delims_impl(PyObject *module)
800802
/* Set the completer function */
801803

802804
/*[clinic input]
805+
@critical_section
803806
readline.set_completer
804807
805808
function: object = None
@@ -814,7 +817,7 @@ It should return the next possible completion starting with 'text'.
814817

815818
static PyObject *
816819
readline_set_completer_impl(PyObject *module, PyObject *function)
817-
/*[clinic end generated code: output=171a2a60f81d3204 input=51e81e13118eb877]*/
820+
/*[clinic end generated code: output=171a2a60f81d3204 input=97f539d8d0bfcb95]*/
818821
{
819822
readlinestate *state = get_readline_state(module);
820823
return set_hook("completer", &state->completer, function);

0 commit comments

Comments
 (0)