ctypes: Correctly handle NULL dlsym values

For dlsym(), a return value of NULL does not necessarily indicate
an error [1].

Therefore, to avoid using stale (or NULL) dlerror() values, we must:

 1. clear the previous error state by calling dlerror()
 2. call dlsym()
 3. call dlerror()

If the return value of dlerror() is not NULL, an error occured.

In our case, we also subjectively treat a NULL return value
from dlsym() as an error, so we format a special string for that.

[1]: https://man7.org/linux/man-pages/man3/dlsym.3.html

Signed-off-by: Georgios Alexopoulos <[email protected]>

Author: grgalex

Misc/NEWS.d/next/C_API/2024-11-07-20-24-58.gh-issue-126554.ri12eb.rst

@@ -0,0 +1 @@
+Correctly handle NULL dlsym() values in ctypes.

Modules/_ctypes/_ctypes.c

@@ -967,18 +967,30 @@ CDataType_in_dll_impl(PyObject *type, PyTypeObject *cls, PyObject *dll,
         return NULL;
     }
 #else
+    dlerror();
     address = (void *)dlsym(handle, name);
-    if (!address) {
 #ifdef __CYGWIN__
-/* dlerror() isn't very helpful on cygwin */
+    if (!address) {
+        /* dlerror() isn't very helpful on cygwin */
         PyErr_Format(PyExc_ValueError,
                      "symbol '%s' not found",
                      name);
+        return NULL;
+    }
 #else
-        PyErr_SetString(PyExc_ValueError, dlerror());
-#endif
+    char *dlerr;
+    dlerr = dlerror();
+    if (dlerr) {
+        PyErr_SetString(PyExc_ValueError, dlerr);
+        return NULL;
+    }
+    else if (!address) {
+        PyErr_Format(PyExc_ValueError,
+                     "symbol '%s' not found",
+                     name);
         return NULL;
     }
+#endif
 #endif
     ctypes_state *st = get_module_state_by_def(Py_TYPE(type));
     return PyCData_AtAddress(st, type, address);
@@ -3774,19 +3786,33 @@ PyCFuncPtr_FromDll(PyTypeObject *type, PyObject *args, PyObject *kwds)
         return NULL;
     }
 #else
+    dlerror();
     address = (PPROC)dlsym(handle, name);
-    if (!address) {
 #ifdef __CYGWIN__
-/* dlerror() isn't very helpful on cygwin */
+    if (!address) {
+        /* dlerror() isn't very helpful on cygwin */
         PyErr_Format(PyExc_AttributeError,
                      "function '%s' not found",
                      name);
+        Py_DECREF(ftuple);
+        return NULL;
+    }
 #else
-        PyErr_SetString(PyExc_AttributeError, dlerror());
-#endif
+    char *dlerr;
+    dlerr = dlerror();
+    if (dlerr) {
+        PyErr_SetString(PyExc_AttributeError, dlerr);
+        Py_DECREF(ftuple);
+        return NULL;
+    }
+    else if (!address) {
+        PyErr_Format(PyExc_AttributeError,
+                     "function '%s' not found",
+                     name);
         Py_DECREF(ftuple);
         return NULL;
     }
+#endif
 #endif
     ctypes_state *st = get_module_state_by_def(Py_TYPE(type));
     if (!_validate_paramflags(st, type, paramflags)) {