gh-122311: Fix a refleak in pickle (GH-122411)

serhiy-storchaka · web-flow · commit 68840e91ac66 · 2024-07-29T21:52:48.000+03:00
diff --git a/Modules/_pickle.c b/Modules/_pickle.c
@@ -3123,6 +3123,7 @@ batch_dict(PickleState *state, PicklerObject *self, PyObject *iter)
             if (!PyTuple_Check(obj) || PyTuple_Size(obj) != 2) {
                 PyErr_SetString(PyExc_TypeError, "dict items "
                                 "iterator must return 2-tuples");
+                Py_DECREF(obj);
                 return -1;
             }
             i = save(state, self, PyTuple_GET_ITEM(obj, 0), 0);

Original file line number	Diff line number	Diff line change
`@@ -3123,6 +3123,7 @@ batch_dict(PickleState state, PicklerObject self, PyObject *iter)`
`3123`	`3123`	`if (!PyTuple_Check(obj) \|\| PyTuple_Size(obj) != 2) {`
`3124`	`3124`	`PyErr_SetString(PyExc_TypeError, "dict items "`
`3125`	`3125`	`"iterator must return 2-tuples");`
	`3126`	`+ Py_DECREF(obj);`
`3126`	`3127`	`return -1;`
`3127`	`3128`	`}`
`3128`	`3129`	`i = save(state, self, PyTuple_GET_ITEM(obj, 0), 0);`