Initialize a variable to make the compiler happy. (GH-9153)

benjaminp · web-flow · commit acd282fd5b3c · 2018-09-11T15:11:06.000-07:00
GCC complains:

Python/pylifecycle.c: In function ‘_Py_InitializeFromConfig’:
Python/pylifecycle.c:900:13: warning: ‘interp’ may be used uninitialized in this function [-Wmaybe-uninitialized]
         err = _Py_InitializeMainInterpreter(interp, &amp;main_config);
         ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This seems spurious since &amp;interp is passed to _Py_InitializeCore. Anyway, we
can easily initialize to quiet the warning.
diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c
@@ -886,7 +886,7 @@ _Py_InitializeMainInterpreter(PyInterpreterState *interp,
 _PyInitError
 _Py_InitializeFromConfig(const _PyCoreConfig *config)
 {
-    PyInterpreterState *interp;
+    PyInterpreterState *interp = NULL;
     _PyInitError err;
     err = _Py_InitializeCore(&interp, config);
     if (_Py_INIT_FAILED(err)) {

Original file line number	Diff line number	Diff line change
`@@ -886,7 +886,7 @@ _Py_InitializeMainInterpreter(PyInterpreterState *interp,`
`886`	`886`	`_PyInitError`
`887`	`887`	`_Py_InitializeFromConfig(const _PyCoreConfig *config)`
`888`	`888`	`{`
`889`		`- PyInterpreterState *interp;`
	`889`	`+ PyInterpreterState *interp = NULL;`
`890`	`890`	`_PyInitError err;`
`891`	`891`	`err = _Py_InitializeCore(&interp, config);`
`892`	`892`	`if (_Py_INIT_FAILED(err)) {`