A stray JUMP_BACKWARD also ends the trace

gvanrossum · gvanrossum · commit c87f9d6d930a · 2023-07-06T21:06:02.000-07:00
diff --git a/Python/optimizer.c b/Python/optimizer.c
@@ -459,9 +459,11 @@ translate_bytecode_to_trace(
                     && trace_length + 3 <= max_length)
                 {
                     ADD_TO_TRACE(JUMP_TO_TOP, 0);
-                    goto done;
                 }
-                // Else fall through!
+                else {
+                    DPRINTF(2, "JUMP_BACKWARD not to top ends trace\n");
+                }
+                goto done;
             }
             default:
             {

Original file line number	Diff line number	Diff line change
`@@ -459,9 +459,11 @@ translate_bytecode_to_trace(`
`459`	`459`	`&& trace_length + 3 <= max_length)`
`460`	`460`	`{`
`461`	`461`	`ADD_TO_TRACE(JUMP_TO_TOP, 0);`
`462`		`- goto done;`
`463`	`462`	`}`
`464`		`- // Else fall through!`
	`463`	`+ else {`
	`464`	`+ DPRINTF(2, "JUMP_BACKWARD not to top ends trace\n");`
	`465`	`+ }`
	`466`	`+ goto done;`
`465`	`467`	`}`
`466`	`468`	`default:`
`467`	`469`	`{`