Skip to content

Commit d29dbb1

Browse files
bpo-42773: fix tests not being run on pushes (GH-24004)
There was a typo, we were checking if the "GITHUB_BASE_REF" string literal was empty instead of the $GITHUB_BASE_REF value. When $GITHUB_BASE_REF is empty, the action that triggered the run was not a pull request, so we always run the full test suite. Signed-off-by: Filipe Laíns <[email protected]> (cherry picked from commit 4ac923f) Co-authored-by: Filipe Laíns <[email protected]>
1 parent 20d4375 commit d29dbb1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- name: Check for source changes
2222
id: check
2323
run: |
24-
if [ -z "GITHUB_BASE_REF" ]; then
24+
if [ -z "$GITHUB_BASE_REF" ]; then
2525
echo '::set-output name=run_tests::true'
2626
else
2727
git fetch origin $GITHUB_BASE_REF --depth=1

0 commit comments

Comments
 (0)