Skip to content

Commit d76d95e

Browse files
[3.12] gh-119050: Add type hints to libregrtest/results.py (GH-119144) (#119157)
gh-119050: Add type hints to libregrtest/results.py (GH-119144) Sort also 'omitted' in TestResults.display_result(). (cherry picked from commit 30b4e9f) Co-authored-by: Victor Stinner <[email protected]>
1 parent bd1e950 commit d76d95e

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

Lib/test/libregrtest/results.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818

1919
class TestResults:
20-
def __init__(self):
20+
def __init__(self) -> None:
2121
self.bad: TestList = []
2222
self.good: TestList = []
2323
self.rerun_bad: TestList = []
@@ -35,22 +35,22 @@ def __init__(self):
3535
# used by --junit-xml
3636
self.testsuite_xml: list = []
3737

38-
def is_all_good(self):
38+
def is_all_good(self) -> bool:
3939
return (not self.bad
4040
and not self.skipped
4141
and not self.interrupted
4242
and not self.worker_bug)
4343

44-
def get_executed(self):
44+
def get_executed(self) -> set[TestName]:
4545
return (set(self.good) | set(self.bad) | set(self.skipped)
4646
| set(self.resource_denied) | set(self.env_changed)
4747
| set(self.run_no_tests))
4848

49-
def no_tests_run(self):
49+
def no_tests_run(self) -> bool:
5050
return not any((self.good, self.bad, self.skipped, self.interrupted,
5151
self.env_changed))
5252

53-
def get_state(self, fail_env_changed):
53+
def get_state(self, fail_env_changed: bool) -> str:
5454
state = []
5555
if self.bad:
5656
state.append("FAILURE")
@@ -195,7 +195,7 @@ def display_result(self, tests: TestTuple, quiet: bool, print_slowest: bool):
195195
omitted = set(tests) - self.get_executed()
196196

197197
# less important
198-
all_tests.append((omitted, "test", "{} omitted:"))
198+
all_tests.append((sorted(omitted), "test", "{} omitted:"))
199199
if not quiet:
200200
all_tests.append((self.skipped, "test", "{} skipped:"))
201201
all_tests.append((self.resource_denied, "test", "{} skipped (resource denied):"))

0 commit comments

Comments
 (0)