-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
Argument Clinic: add support for renaming a parameter #108271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Brainstorming regarding syntax, my first thought would be to modify
Something like this would be cleaner:
Here's another alternative, which require changes to
|
An
|
I considered similar variants:
In addition to adding this feature we can add also allow add a parameter alias without deprecating the old name. One feature can be considered an extension of the other. What are ideas for this syntax? How can it be extended to add the deprecation of the old name? Should we support more than two names for the same parameter? |
I think there is value in keeping the DSL simple, so perhaps an argument to converter is the best option. I agree it is not ideal mixing converter and param arguments, but as you say, we already do. |
I worry that the decorator variant will be too complex for little gain. I agree it also looks weird. |
Originally posted by @serhiy-storchaka in #95065 (comment):
The text was updated successfully, but these errors were encountered: