PyThreadState_IsCurrent bug under building Python with --with-experimental-isolated-subinterpreters

[JunyiXie]

BPO	44374
Nosy	@vstinner, @JunyiXie

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2021-06-10.10:14:52.708>
labels = ['expert-subinterpreters', '3.11']
title = 'PyThreadState_IsCurrent bug under building Python with --with-experimental-isolated-subinterpreters'
updated_at = <Date 2021-06-10.10:14:52.708>
user = 'https://github.com/JunyiXie'

bugs.python.org fields:

activity = <Date 2021-06-10.10:14:52.708>
actor = 'JunyiXie'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Subinterpreters']
creation = <Date 2021-06-10.10:14:52.708>
creator = 'JunyiXie'
dependencies = []
files = []
hgrepos = []
issue_num = 44374
keywords = []
message_count = 1.0
messages = ['395517']
nosy_count = 2.0
nosy_names = ['vstinner', 'JunyiXie']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue44374'
versions = ['Python 3.11']

[JunyiXie]

under building Python with --with-experimental-isolated-subinterpreters
PyThreadState_IsCurrent use _PyRuntime.gilstate. is shared by multi sub interpreters.
Use interpreter gil->last_holder == state can fix it?

static int
PyThreadState_IsCurrent(PyThreadState *tstate)
{
    /* Must be the tstate for this thread */
    struct _gilstate_runtime_state *gilstate = &_PyRuntime.gilstate;
    assert(_PyGILState_GetThisThreadState(gilstate) == tstate);
    return tstate == _PyRuntimeGILState_GetThreadState(gilstate);
}

static int
PyThreadState_IsCurrent(PyThreadState *tstate)
{
#ifdef EXPERIMENTAL_ISOLATED_SUBINTERPRETERS
    PyInterpreterState *interp = tstate->interp;
    struct _ceval_state *ceval2 = &interp->ceval;
    struct _gil_runtime_state *gil = &ceval2->gil;
    return tstate == (PyThreadState*)_Py_atomic_load_relaxed(&gil->last_holder);
#else
    /* Must be the tstate for this thread */
    struct _gilstate_runtime_state *gilstate = &_PyRuntime.gilstate;
    assert(_PyGILState_GetThisThreadState(gilstate) == tstate);
    return tstate == _PyRuntimeGILState_GetThreadState(gilstate);
#endif
}

[kumaraditya303]

Closing as EXPERIMENTAL_ISOLATED_SUBINTERPRETERS was removed in #93185