asyncio.streams.open_connection remove loop from docstring #108528
Conversation
asyncio.streams.open_connection no longer accepts loop as a keyword argument and providing it causes: TypeError: BaseEventLoop.create_connection() got an unexpectedkeyword argument 'loop' therefore remove it from the docstring.
tgbugs
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
This is a trivial change so if someone who has signed the CLA wants to submit it I don't mind. |
gvanrossum
added
needs backport to 3.11
|
@tgbugs: Could you please sign the CLA? It would really be much easier that way -- I can't merge without it. |
|
@gvanrossum CLA signed. |
|
Thanks @tgbugs for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…nGH-108528) (cherry picked from commit e721f7a) Co-authored-by: Tom Gillespie <[email protected]>
|
GH-109941 is a backport of this pull request to the 3.12 branch. |
…nGH-108528) (cherry picked from commit e721f7a) Co-authored-by: Tom Gillespie <[email protected]>
|
GH-109942 is a backport of this pull request to the 3.11 branch. |
|
@tgbugs I just realized (seconds after merging :-) that a similar change needs to be applied to open_connection(). Are you interested in taking that on, now that you've got the CLA signed and all? |
…GH-108528) (#109942) Remove loop from docstring for asyncio.streams.open_connection (GH-108528) (cherry picked from commit e721f7a) Co-authored-by: Tom Gillespie <[email protected]>
|
Happy to, but won't be able to get to it until late next week of that
matters.
…On Wed, Sep 27, 2023, 12:42 Guido van Rossum ***@***.***> wrote:
@tgbugs <https://github.com/tgbugs> I just realized (seconds after
merging :-) that a similar change needs to be applied to open_connection().
Are you interested in taking that on, now that you've got the CLA signed
and all?
—
Reply to this email directly, view it on GitHub
<#108528 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAZYABLAISZZEKVQDC75XLX4OOCRANCNFSM6AAAAAA4ABRYYM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@tgbugs No problem, take your time. |
…GH-108528) (#109941) Remove loop from docstring for asyncio.streams.open_connection (GH-108528) (cherry picked from commit e721f7a) Co-authored-by: Tom Gillespie <[email protected]>
asyncio.streams.open_connection no longer accepts loop as a keyword argument and providing it causes:
TypeError: BaseEventLoop.create_connection() got an unexpectedkeyword argument 'loop' therefore remove it from the docstring.