From b3a66d31f632f7faeb30a25747887ad1344dd142 Mon Sep 17 00:00:00 2001 From: sobolevn Date: Mon, 9 Oct 2023 20:34:00 +0300 Subject: [PATCH 1/3] Fix CIFuzz build --- .github/workflows/build.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 277042dfda1903..cc1efc86b715d4 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -86,7 +86,9 @@ jobs: # The tests are pretty slow so they are executed only for PRs # changing relevant files. FUZZ_RELEVANT_FILES='(\.c$|\.h$|\.cpp$|^configure$|^\.github/workflows/build\.yml$|^Modules/_xxtestfuzz)' - git diff --name-only origin/$GITHUB_BASE_REF.. | grep -qvE $FUZZ_RELEVANT_FILES && echo "run_cifuzz=true" >> $GITHUB_OUTPUT || true + git diff --name-only origin/$GITHUB_BASE_REF.. | grep -qvE $FUZZ_RELEVANT_FILES && echo "run_cifuzz=true" >> $GITHUB_OUTPUT + else + echo "run_cifuzz=false" >> $GITHUB_OUTPUT fi - name: Compute hash for config cache key id: config_hash From 0348cbc521eada1c4f4a045ceb588040d97c3992 Mon Sep 17 00:00:00 2001 From: sobolevn Date: Mon, 9 Oct 2023 20:47:54 +0300 Subject: [PATCH 2/3] Fix CI --- .github/workflows/build.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index cc1efc86b715d4..b971f94ae8a4c8 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -82,12 +82,14 @@ jobs: # CPython, so CIFuzz should be run only for code that is likely to be # merged into the main branch; compatibility with older branches may # be broken. - if [ "$GITHUB_BASE_REF" = "main" ]; then + FUZZ_RELEVANT_FILES='(\.c$|\.h$|\.cpp$|^configure$|^\.github/workflows/build\.yml$|^Modules/_xxtestfuzz)' + if [ "$GITHUB_BASE_REF" = "main" ] && [ "$(git diff --name-only origin/$GITHUB_BASE_REF.. | grep -qvE $FUZZ_RELEVANT_FILES; echo $?)" -eq 1 ]; then # The tests are pretty slow so they are executed only for PRs # changing relevant files. - FUZZ_RELEVANT_FILES='(\.c$|\.h$|\.cpp$|^configure$|^\.github/workflows/build\.yml$|^Modules/_xxtestfuzz)' - git diff --name-only origin/$GITHUB_BASE_REF.. | grep -qvE $FUZZ_RELEVANT_FILES && echo "run_cifuzz=true" >> $GITHUB_OUTPUT + echo "Run CIFuzz tests" + echo "run_cifuzz=true" >> $GITHUB_OUTPUT else + echo "Branch too old for CIFuzz tests; or no C files were changed" echo "run_cifuzz=false" >> $GITHUB_OUTPUT fi - name: Compute hash for config cache key From 3a5a4496d0e1bfd461b0169f0bb18d7d778b7fa0 Mon Sep 17 00:00:00 2001 From: sobolevn Date: Tue, 10 Oct 2023 01:08:43 +0300 Subject: [PATCH 3/3] Address review --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b971f94ae8a4c8..848d13fae34e26 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -83,7 +83,7 @@ jobs: # merged into the main branch; compatibility with older branches may # be broken. FUZZ_RELEVANT_FILES='(\.c$|\.h$|\.cpp$|^configure$|^\.github/workflows/build\.yml$|^Modules/_xxtestfuzz)' - if [ "$GITHUB_BASE_REF" = "main" ] && [ "$(git diff --name-only origin/$GITHUB_BASE_REF.. | grep -qvE $FUZZ_RELEVANT_FILES; echo $?)" -eq 1 ]; then + if [ "$GITHUB_BASE_REF" = "main" ] && [ "$(git diff --name-only origin/$GITHUB_BASE_REF.. | grep -qE $FUZZ_RELEVANT_FILES; echo $?)" ]; then # The tests are pretty slow so they are executed only for PRs # changing relevant files. echo "Run CIFuzz tests"