From c3994fa7aa5ab40b120c733efa987ad862c8a4d1 Mon Sep 17 00:00:00 2001 From: Peter Marko Date: Mon, 10 Feb 2025 10:51:56 +0100 Subject: [PATCH] gh-126554: correct detection of `gcc` for `TestNullDlsym.test_null_dlsym` (GH-129872) In case gcc is not available, the test will fail with FileNotFoundError. So catch the exception to skip the test correctly. (cherry picked from commit 978211c8a8646b050a8d687ca720f934fcce112c) Co-authored-by: Peter Marko Signed-off-by: Peter Marko --- Lib/test/test_ctypes/test_dlerror.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/Lib/test/test_ctypes/test_dlerror.py b/Lib/test/test_ctypes/test_dlerror.py index 6bf492399cbf95..1c1b2aab3d589e 100644 --- a/Lib/test/test_ctypes/test_dlerror.py +++ b/Lib/test/test_ctypes/test_dlerror.py @@ -58,11 +58,14 @@ def test_null_dlsym(self): import subprocess import tempfile - retcode = subprocess.call(["gcc", "--version"], - stdout=subprocess.DEVNULL, - stderr=subprocess.DEVNULL) - if retcode != 0: + try: + retcode = subprocess.call(["gcc", "--version"], + stdout=subprocess.DEVNULL, + stderr=subprocess.DEVNULL) + except OSError: self.skipTest("gcc is missing") + if retcode != 0: + self.skipTest("gcc --version failed") pipe_r, pipe_w = os.pipe() self.addCleanup(os.close, pipe_r)