From 40518472332560f53e5d830b90cc42d1eecacbb4 Mon Sep 17 00:00:00 2001 From: Michael Felt Date: Wed, 12 Jun 2019 11:07:02 +0000 Subject: [PATCH 1/2] Skip `test_asyncio.test_create_connection_ipv6_scope` on AIX because "getaddrinfo()" behaves different on AIX --- Lib/test/test_asyncio/test_base_events.py | 1 + .../next/Tests/2019-06-12-11-02-06.bpo-35545.s63eHE.rst | 4 ++++ 2 files changed, 5 insertions(+) create mode 100644 Misc/NEWS.d/next/Tests/2019-06-12-11-02-06.bpo-35545.s63eHE.rst diff --git a/Lib/test/test_asyncio/test_base_events.py b/Lib/test/test_asyncio/test_base_events.py index 02a97c60ac1a93..d1b5fd4bacaeda 100644 --- a/Lib/test/test_asyncio/test_base_events.py +++ b/Lib/test/test_asyncio/test_base_events.py @@ -1298,6 +1298,7 @@ def _test_create_connection_ip_addr(self, m_socket, allow_inet_pton): t.close() test_utils.run_briefly(self.loop) # allow transport to close + @unittest.skipIf(sys.platform.startswith('aix'), "getaddrinfo() different on AIX") @patch_socket def test_create_connection_ipv6_scope(self, m_socket): m_socket.getaddrinfo = socket.getaddrinfo diff --git a/Misc/NEWS.d/next/Tests/2019-06-12-11-02-06.bpo-35545.s63eHE.rst b/Misc/NEWS.d/next/Tests/2019-06-12-11-02-06.bpo-35545.s63eHE.rst new file mode 100644 index 00000000000000..1a9c9822cbb6cd --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2019-06-12-11-02-06.bpo-35545.s63eHE.rst @@ -0,0 +1,4 @@ +Skip `test_asyncio.test_create_connection_ipv6_scope` on AIX +because "getaddrinfo()" behaves different on AIX + +Patch by M. Felt From 6f7438d80f756414a40c7f4b1e3e7aa7e757eecb Mon Sep 17 00:00:00 2001 From: Michael Felt Date: Wed, 12 Jun 2019 11:41:44 +0000 Subject: [PATCH 2/2] modifications per peer review --- Lib/test/test_asyncio/test_base_events.py | 3 ++- .../next/Tests/2019-06-12-11-02-06.bpo-35545.s63eHE.rst | 4 ---- 2 files changed, 2 insertions(+), 5 deletions(-) delete mode 100644 Misc/NEWS.d/next/Tests/2019-06-12-11-02-06.bpo-35545.s63eHE.rst diff --git a/Lib/test/test_asyncio/test_base_events.py b/Lib/test/test_asyncio/test_base_events.py index d1b5fd4bacaeda..811b37425dd287 100644 --- a/Lib/test/test_asyncio/test_base_events.py +++ b/Lib/test/test_asyncio/test_base_events.py @@ -1298,7 +1298,8 @@ def _test_create_connection_ip_addr(self, m_socket, allow_inet_pton): t.close() test_utils.run_briefly(self.loop) # allow transport to close - @unittest.skipIf(sys.platform.startswith('aix'), "getaddrinfo() different on AIX") + @unittest.skipIf(sys.platform.startswith('aix'), + "bpo-25545: IPv6 scope id and getaddrinfo() behave differently on AIX") @patch_socket def test_create_connection_ipv6_scope(self, m_socket): m_socket.getaddrinfo = socket.getaddrinfo diff --git a/Misc/NEWS.d/next/Tests/2019-06-12-11-02-06.bpo-35545.s63eHE.rst b/Misc/NEWS.d/next/Tests/2019-06-12-11-02-06.bpo-35545.s63eHE.rst deleted file mode 100644 index 1a9c9822cbb6cd..00000000000000 --- a/Misc/NEWS.d/next/Tests/2019-06-12-11-02-06.bpo-35545.s63eHE.rst +++ /dev/null @@ -1,4 +0,0 @@ -Skip `test_asyncio.test_create_connection_ipv6_scope` on AIX -because "getaddrinfo()" behaves different on AIX - -Patch by M. Felt